Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translations #7

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Add Spanish translations #7

merged 1 commit into from
Apr 17, 2017

Conversation

m1guelpf
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 14, 2017

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #7   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       27     27           
=======================================
  Files             5      5           
  Lines            75     75           
=======================================
  Hits             75     75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06eb34...3c7e937. Read the comment docs.

@m1guelpf m1guelpf mentioned this pull request Apr 14, 2017
@m1guelpf
Copy link
Contributor Author

@clarkeash What do you think?

@clarkeash
Copy link
Owner

I am in 2 minds about this:

I think it would be really cool to have other languages supported out of the box, however I have no way of knowing what the translation actually says, and if I add a message in the future the Spanish translation then becomes out of date.

Even with this said, I am tempted to merge.

@m1guelpf
Copy link
Contributor Author

@clarkeash It's always better to have an outdated translation than not havin anything. Also, I can mantain it if you ping me every time you add a new message.

@clarkeash
Copy link
Owner

Ill merge it and we can see how it goes.

@clarkeash clarkeash merged commit 7bedbbb into clarkeash:master Apr 17, 2017
@m1guelpf m1guelpf deleted the patch-2 branch April 17, 2017 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants