Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluator fails impredicative type instantiation of error values #2272

Closed
christiaanb opened this issue Jul 6, 2022 · 1 comment · Fixed by #2273
Closed

Evaluator fails impredicative type instantiation of error values #2272

christiaanb opened this issue Jul 6, 2022 · 1 comment · Fixed by #2273

Comments

@christiaanb
Copy link
Member 

{-# LANGUAGE ImpredicativeTypes, TypeApplications, GADTs #-}
module ImpredErr where

import Clash.Prelude

data Ex where
  ExT :: (forall a . String -> a) -> Ex

f :: Ex
f = ExT (errorX @(forall b . String -> b) "qq")
{-# NOINLINE f #-}

topEntity :: Int
topEntity = case f of
  ExT h -> h "kk"

fails with:

    Clash error call:
    Evaluator.instantiate: Not a tylambda: PrimVal (PrimInfo {primName = "Clash.XException.errorX", primType = ForAllTy (TyVar {varName = Name {nameSort = User, nameOcc = "a", nameUniq = 6989586621679042592, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}, varUniq = 6989586621679042592, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))}) (AppTy (AppTy (ConstTy Arrow) (AppTy (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Classes.IP", nameUniq = 3602879701896396848, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (LitTy (SymTy "callStack"))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Stack.Types.CallStack", nameUniq = 3674937295934325108, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))))) (AppTy (AppTy (ConstTy Arrow) (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.[]", nameUniq = 3674937295934324788, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.Char", nameUniq = 3674937295934324752, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))))) (VarTy (TyVar {varName = Name {nameSort = User, nameOcc = "a", nameUniq = 6989586621679042592, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}, varUniq = 6989586621679042592, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))})))), primWorkInfo = WorkConstant, primMultiResult = SingleResult, primUnfolding = Unfolding (Id {varName = Name {nameSort = User, nameOcc = "Clash.XException.errorX", nameUniq = 8214565720323787764, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}, varUniq = 8214565720323787764, varType = ForAllTy (TyVar {varName = Name {nameSort = User, nameOcc = "a", nameUniq = 6989586621679042592, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}, varUniq = 6989586621679042592, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, 
nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))}) (AppTy (AppTy (ConstTy Arrow) (AppTy (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Classes.IP", nameUniq = 3602879701896396848, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (LitTy (SymTy "callStack"))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Stack.Types.CallStack", nameUniq = 3674937295934325108, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))))) (AppTy (AppTy (ConstTy Arrow) (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.[]", nameUniq = 3674937295934324788, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.Char", nameUniq = 3674937295934324752, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))))) (VarTy (TyVar {varName = Name {nameSort = User, nameOcc = "a", nameUniq = 6989586621679042592, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}, varUniq = 6989586621679042592, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))})))), idScope = GlobalId})}) [ForAllTy (TyVar {varName = Name {nameSort = User, nameOcc = "b", nameUniq = 6989586621679042239, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 26 27}, varUniq = 6989586621679042239, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))}) (AppTy (AppTy (ConstTy Arrow) (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.[]", nameUniq = 3674937295934324788, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.Char", nameUniq = 3674937295934324752, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))))) (VarTy (TyVar {varName = Name {nameSort = User, nameOcc = "b", nameUniq = 6989586621679042239, 
nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 26 27}, varUniq = 6989586621679042239, varType = AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Prim.TYPE", nameUniq = 3674937295934324912, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.LiftedRep", nameUniq = 3891110078048108766, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))})))] [Suspend (TyApp (Prim (PrimInfo {primName = "Clash.Normalize.Primitives.removedArg", primType = ForAllTy (TyVar {varName = Name {nameSort = System, nameOcc = "a", nameUniq = 0, nameLoc = UnhelpfulSpan "<no location info>"}, varUniq = 0, varType = ConstTy (TyCon (Name {nameSort = System, nameOcc = "Type", nameUniq = 3674937295934324910, nameLoc = UnhelpfulSpan "<no location info>"}))}) (VarTy (TyVar {varName = Name {nameSort = System, nameOcc = "a", nameUniq = 0, nameLoc = UnhelpfulSpan "<no location info>"}, varUniq = 0, varType = ConstTy (TyCon (Name {nameSort = System, nameOcc = "Type", nameUniq = 3674937295934324910, nameLoc = UnhelpfulSpan "<no location info>"}))})), primWorkInfo = WorkNever, primMultiResult = SingleResult, primUnfolding = NoUnfolding})) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Stack.Types.CallStack", nameUniq = 3674937295934325108, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))),Suspend (TyApp (Prim (PrimInfo {primName = "Clash.Normalize.Primitives.removedArg", primType = ForAllTy (TyVar {varName = Name {nameSort = System, nameOcc = "a", nameUniq = 0, nameLoc = UnhelpfulSpan "<no location info>"}, varUniq = 0, 
varType = ConstTy (TyCon (Name {nameSort = System, nameOcc = "Type", nameUniq = 3674937295934324910, nameLoc = UnhelpfulSpan "<no location info>"}))}) (VarTy (TyVar {varName = Name {nameSort = System, 
nameOcc = "a", nameUniq = 0, nameLoc = UnhelpfulSpan "<no location info>"}, varUniq = 0, varType = ConstTy (TyCon (Name {nameSort = System, nameOcc = "Type", nameUniq = 3674937295934324910, nameLoc = UnhelpfulSpan "<no location info>"}))})), primWorkInfo = WorkNever, primMultiResult = SingleResult, primUnfolding = NoUnfolding})) (AppTy (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.[]", nameUniq = 3674937295934324788, nameLoc = RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48}))) (ConstTy (TyCon (Name {nameSort = User, nameOcc = "GHC.Types.Char", nameUniq = 3674937295934324752, nameLoc 
= RealSrcSpan SrcSpanOneLine "Test.hs" 10 9 48})))))]
    CallStack (from HasCallStack):
      error, called at src-ghc\\Clash\\GHC\\Evaluator.hs:348:23 in clash-ghc-1.7.0-inplace:Clash.GHC.Evaluator
christiaanb added a commit that referenced this issue Jul 6, 2022
@christiaanb
Handle impredicative instantiation of error values
85d19bf 
Fixes #2272
@christiaanb christiaanb mentioned this issue Jul 6, 2022
Merged
2 tasks
christiaanb added a commit that referenced this issue Jul 6, 2022
@christiaanb
Handle impredicative instantiation of error values
e8d7f2f 
Fixes #2272
christiaanb added a commit that referenced this issue Jul 6, 2022
@christiaanb
Handle impredicative instantiation of error values
543bb30 
Fixes #2272
christiaanb added a commit that referenced this issue Jul 6, 2022
@christiaanb
Handle impredicative instantiation of error values
106974b 
Fixes #2272
christiaanb added a commit that referenced this issue Jul 7, 2022
@christiaanb
Handle impredicative instantiation of error values
abb82c1 
Fixes #2272
christiaanb added a commit that referenced this issue Jul 8, 2022
@christiaanb
Handle impredicative instantiation of error values
b234caf 
Fixes #2272
mergify bot pushed a commit that referenced this issue Jul 8, 2022
@christiaanb @mergify
Handle impredicative instantiation of error values
ff8ee4c 
Fixes #2272

(cherry picked from commit b234caf)

# Conflicts:
#	tests/Main.hs
christiaanb added a commit that referenced this issue Jul 8, 2022
@christiaanb
Handle impredicative instantiation of error values
bea8c99 
Fixes #2272

(cherry picked from commit b234caf)
christiaanb added a commit that referenced this issue Jul 12, 2022
@christiaanb
Handle impredicative instantiation of error values
7888a52 
Fixes #2272

(cherry picked from commit b234caf)
@martijnbastiaan
Copy link
Member

We've released v1.6.4, which includes a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle impredicative instantiation of error values clash-lang/clash-compiler
2 participants
@christiaanb @martijnbastiaan