Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hashable 1.4.1.0 #2449

Merged
merged 1 commit into from Apr 13, 2023
Merged

Add support for hashable 1.4.1.0 #2449

merged 1 commit into from Apr 13, 2023

Conversation

martijnbastiaan
Copy link
Member

@martijnbastiaan martijnbastiaan commented Apr 13, 2023 •
edited

>=1.4.2.0 support was added in #2448, <1.4.1.0 was already supported.

@martijnbastiaan martijnbastiaan enabled auto-merge (squash) April 13, 2023 08:41
@martijnbastiaan
Copy link
Member Author

Tested locally with:

cabal build clash-lib --with-compiler=ghc-8.10.7 --constraint=hashable==1.4.0.0
cabal build clash-lib --with-compiler=ghc-8.10.7 --constraint=hashable==1.4.1.0
cabal build clash-lib --with-compiler=ghc-8.10.7 --constraint=hashable==1.4.2.0

# Cabal can't find a build plan for GHC 9.2 + hashable==1.4.0.0
# cabal build clash-lib --with-compiler=ghc-9.2.5 --constraint=hashable==1.4.0.0
cabal build clash-lib --with-compiler=ghc-9.2.5 --constraint=hashable==1.4.1.0
cabal build clash-lib --with-compiler=ghc-9.2.5 --constraint=hashable==1.4.2.0

@martijnbastiaan
Add support for hashable 1.4.1.0
98546b1 
>=1.4.2.0 support was added in #2448, <1.4.1.0 was already supported.
@martijnbastiaan martijnbastiaan merged commit 7e714a5 into master Apr 13, 2023
11 checks passed
@martijnbastiaan martijnbastiaan deleted the hashable-1.4.1.0 branch April 13, 2023 09:37
@martijnbastiaan martijnbastiaan mentioned this pull request Apr 19, 2023
Closed
DigitalBrains1 added a commit that referenced this pull request Apr 28, 2023
@DigitalBrains1
Correct logic when to orphan Hashable ByteArray
c9137ed 
PR #2448 and #2449 were incomplete, missing some cases where we still
needed to create an orphan instance for Hashable ByteArray ourselves.
This should get it right, including for when we will support GHC 9.4
(which is guarded by the expression `MIN_VERSION_base(4,17,0)`).
@DigitalBrains1 DigitalBrains1 mentioned this pull request Apr 28, 2023
Merged
1 task
DigitalBrains1 added a commit that referenced this pull request Apr 28, 2023
@DigitalBrains1
Correct logic when to orphan Hashable ByteArray (#2460)
c56131d 
PR #2448 and #2449 were incomplete, missing some cases where we still
needed to create an orphan instance for `Hashable ByteArray` ourselves.
This should get it right, including for when we will support GHC 9.4
(which is guarded by the expression `MIN_VERSION_base(4,17,0)`).

Fixes #2453
DigitalBrains1 added a commit that referenced this pull request Jun 2, 2023
@DigitalBrains1
Restrict when to create orphan Hashable ByteArray
f7e3a75 
This is a backport of a combination of PR's #2448, #2449 and #2460.

For some combinations of `hashable` and `primitive`, there is already a
`Hashable ByteArray` instance and we should not create one.
@DigitalBrains1 DigitalBrains1 mentioned this pull request Jun 2, 2023
Merged
1 task
DigitalBrains1 added a commit that referenced this pull request Jun 2, 2023
@DigitalBrains1
Restrict when to create orphan Hashable ByteArray (#2485)
dbd3f7c 
This is a backport of a combination of PR's #2448, #2449 and #2460.

For some combinations of `hashable` and `primitive`, there is already a
`Hashable ByteArray` instance and we should not create one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martijnbastiaan