Correct logic when to orphan Hashable ByteArray

[DigitalBrains1]

PR #2448 and #2449 were incomplete, missing some cases where we still needed to create an orphan instance for Hashable ByteArray ourselves. This should get it right, including for when we will support GHC 9.4 (which is guarded by the expression MIN_VERSION_base(4,17,0)).

Note that the Package Versioning Policy has something to say about defining orphan instances like this:

Client defines orphan instance. If a package defines an orphan instance, it MUST depend on the minor version of the packages that define the data type and the type class to be backwards compatible. For example, build-depends: mypkg >= 2.1.1 && < 2.1.2.

I think we used to violate this rule, but not any longer :-). Because we now switch off the orphan instance generation starting at a certain version of the dependencies, so we can freely depend in the usual only-major fashion on them again.

Why to be backwards compatible though? The problem here was forwards compatibility, it seems to go both ways. Maybe a simple case of phrasing, or you're supposed to switch your view point, it's always backwards from one side ;-).

Fixes #2453

Still TODO:

• Write a changelog entry (see changelog/README.md)
• Check copyright notices are up to date in edited files

[DigitalBrains1]

I will add

Fixes #2453

to the commit msg when I squash merge. Forgot that.

[martijnbastiaan]

LGTM, I'm running the script I posted earlier to verify that this works.

[DigitalBrains1]

If it gives a different result on clash-compiler than it does on test-hashable-primitive I will eat my hat! Not right away, left it at home.

[martijnbastiaan]

LGTM

OK:   ghc-9.2.7, hashable-1.4.2.0, primitive-0.7.4.0
OK:   ghc-9.2.7, hashable-1.4.0.2, primitive-0.8.0.0
OK:   ghc-9.2.7, hashable-1.4.1.0, primitive-0.8.0.0
OK:   ghc-9.2.7, hashable-1.4.0.2, primitive-0.7.4.0
OK:   ghc-9.2.7, hashable-1.4.2.0, primitive-0.8.0.0
OK:   ghc-9.2.7, hashable-1.4.1.0, primitive-0.7.4.0
OK:   ghc-9.0.2, hashable-1.4.1.0, primitive-0.8.0.0
OK:   ghc-9.0.2, hashable-1.4.1.0, primitive-0.7.4.0
OK:   ghc-9.0.2, hashable-1.4.2.0, primitive-0.7.4.0
OK:   ghc-9.0.2, hashable-1.4.0.2, primitive-0.8.0.0
OK:   ghc-9.0.2, hashable-1.4.0.2, primitive-0.7.4.0
OK:   ghc-9.0.2, hashable-1.4.2.0, primitive-0.8.0.0
OK:   ghc-8.10.7, hashable-1.4.2.0, primitive-0.8.0.0
OK:   ghc-8.10.7, hashable-1.4.2.0, primitive-0.7.4.0
OK:   ghc-8.10.7, hashable-1.4.1.0, primitive-0.8.0.0
OK:   ghc-8.10.7, hashable-1.4.1.0, primitive-0.7.4.0
OK:   ghc-8.10.7, hashable-1.4.0.2, primitive-0.8.0.0
OK:   ghc-8.10.7, hashable-1.4.0.2, primitive-0.7.4.0
OK:   ghc-8.8.4, hashable-1.4.2.0, primitive-0.8.0.0
OK:   ghc-8.8.4, hashable-1.4.2.0, primitive-0.7.4.0
OK:   ghc-8.8.4, hashable-1.4.1.0, primitive-0.7.4.0
OK:   ghc-8.8.4, hashable-1.4.1.0, primitive-0.8.0.0
OK:   ghc-8.8.4, hashable-1.4.0.2, primitive-0.7.4.0
OK:   ghc-8.8.4, hashable-1.4.0.2, primitive-0.8.0.0
OK:   ghc-8.6.5, hashable-1.4.1.0, primitive-0.8.0.0
OK:   ghc-8.6.5, hashable-1.4.1.0, primitive-0.7.4.0
OK:   ghc-8.6.5, hashable-1.4.2.0, primitive-0.7.4.0
OK:   ghc-8.6.5, hashable-1.4.2.0, primitive-0.8.0.0
OK:   ghc-8.6.5, hashable-1.4.0.2, primitive-0.8.0.0
OK:   ghc-8.6.5, hashable-1.4.0.2, primitive-0.7.4.0