Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict when to create orphan Hashable ByteArray #2485

Merged
merged 1 commit into from Jun 2, 2023
Merged

Restrict when to create orphan Hashable ByteArray #2485

merged 1 commit into from Jun 2, 2023

Conversation

DigitalBrains1
Copy link
Member

This is a backport of a combination of PR's #2448, #2449 and #2460.

For some combinations of hashable and primitive, there is already a Hashable ByteArray instance and we should not create one.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@DigitalBrains1
Restrict when to create orphan Hashable ByteArray
f7e3a75 
This is a backport of a combination of PR's #2448, #2449 and #2460.

For some combinations of `hashable` and `primitive`, there is already a
`Hashable ByteArray` instance and we should not create one.
@DigitalBrains1 DigitalBrains1 merged commit dbd3f7c into 1.6 Jun 2, 2023
10 checks passed
@DigitalBrains1 DigitalBrains1 deleted the orphan-hash-bytearray-1.6 branch June 2, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnbastiaan martijnbastiaan martijnbastiaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DigitalBrains1 @martijnbastiaan