Updated etcd bootstrap scripts to allow for idempotency #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
prometherion
requested changes
Oct 10, 2023
| @@ -15,7 +15,7 @@ rules: | |||
| resources: | |||
| - secrets | |||
| verbs: | |||
| - delete | |||
There was a problem hiding this comment.
The delete is still required for the post-delete job of the etcd component.
We should rather add the get verb and not remove the delete one.
There was a problem hiding this comment.
Yep, I missed that. Has been re-added in the latest commit
prometherion
requested changes
Oct 10, 2023
prometherion
approved these changes
Oct 10, 2023
sn4psh0t
added a commit
to sn4psh0t/kamaji-etcd
that referenced
this pull request
Nov 20, 2023
- etcd-setup-1 preinstall script checks for CA and client secrets existence - etcd-setup-2 postinstall script checks for root user existence Inspired to clastix/kamaji#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated etcd bootstrap scripts to allow for idempotency
Adjusted etc rbac role to let pod get current secrets