Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: admin kubeconfig with local service FQDN #403

Merged
merged 1 commit into from
Jan 22, 2024
Merged

feat: admin kubeconfig with local service FQDN #403

merged 1 commit into from
Jan 22, 2024

Conversation

prometherion
Copy link
Member

For the admin generated kubeconfig resources, a new key to the Secret data is added, such as admin.conf and admin.svc.

The latter one is the same kubeconfig but points to the Service FQDN, which could be useful to avoid LB hops. This feature doesn't introduce breaking changes.

@prometherion
feat: admin kubeconfig with local service FQDN
a59b450 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit a59b450
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/65ae7af76bc7a300073e7633

@prometherion prometherion added this to the v0.5.0 milestone Jan 22, 2024
@prometherion prometherion merged commit 25dc19f into clastix:master Jan 22, 2024
10 checks passed
@prometherion prometherion deleted the feat/svc-kubeconfig branch January 22, 2024 17:50
@prometherion prometherion modified the milestones: v0.5.0, v0.4.1 Jan 26, 2024
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Feb 5, 2024
@kvaps
Allow overriding secretKey for kubeconfig
d57dc5f 
During reconciliation, the control plane provider copies the content from the secret provided by Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig, which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the KamajiControlPlane resource. This annotation instructs the control plane provider to read the kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: admin.svc
```

This will instruct the system to use `admin.svc` a kubeconfig with a local service FQDN (introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps mentioned this pull request Feb 5, 2024
Merged
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Feb 5, 2024
@kvaps
Allow overriding secretKey for kubeconfig
c654550 
During reconciliation, the control plane provider copies the content from the secret provided by Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig, which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the KamajiControlPlane resource. This annotation instructs the control plane provider to read the kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: admin.svc
```

This will instruct the system to use `admin.svc` a kubeconfig with a local service FQDN (introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps mentioned this pull request Feb 5, 2024
Merged
kvaps added a commit to aenix-io/kamaji that referenced this pull request Feb 5, 2024
@kvaps
Allow overriding secretKey for kubeadm kubeconfig
dc7f6ee 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Feb 5, 2024
@kvaps
Allow overriding secretKey for kubeconfig
4a98610 
During reconciliation, the control plane provider copies the content from the secret provided by Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig, which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the KamajiControlPlane resource. This annotation instructs the control plane provider to read the kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/kamaji that referenced this pull request Feb 5, 2024
@kvaps
Allow overriding secretKey for kubeadm kubeconfig
765d7fd 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/kamaji that referenced this pull request Mar 5, 2024
@kvaps
Allow overriding secretKey for kubeadm kubeconfig
6df5b94 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/kamaji that referenced this pull request Mar 5, 2024
@kvaps
Allow overriding secretKey for kubeadm kubeconfig
5324710 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/kamaji that referenced this pull request Mar 5, 2024
@kvaps
Allow overriding secretKey for kubeadm kubeconfig
294d70a 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by clastix#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
prometherion pushed a commit that referenced this pull request Apr 18, 2024
@kvaps @prometherion
Allow overriding secretKey for kubeadm kubeconfig
ced34a5 
During reconciliation, the bootstrap provider copies the content from the secret provided by Kamaji, named `<cluster>-admin-kubeconfig` into a `cluster-info` configmap of tenant cluster, which then used by kubeadm to join nodes.

This change introduces a new annotation, `kamaji.clastix.io/kubeconfig-secret-key`, for the TenantControlPlane resource. This annotation instructs kamaji to read the kubeconfig from a specific key (the default one is super-admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: super-admin.svc
```

This will instruct the system to use `super-admin.svc` a kubeconfig with a local service FQDN (introduced by #403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Apr 22, 2024
@kvaps
Allow overriding secretKey for kubeconfig
86ab061 
During reconciliation, the control plane provider copies the content from the secret provided by Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig, which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the KamajiControlPlane resource. This annotation instructs the control plane provider to read the kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: admin.svc
```

This will instruct the system to use `admin.svc` a kubeconfig with a local service FQDN (introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Apr 22, 2024
@kvaps
feat: allow overriding secretKey for kubeconfig
19b83d6 
During reconciliation, the control plane provider copies the content from the secret provided by Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig, which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the KamajiControlPlane resource. This annotation instructs the control plane provider to read the kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: admin.svc
```

This will instruct the system to use `admin.svc` a kubeconfig with a local service FQDN (introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps added a commit to aenix-io/cluster-api-control-plane-provider-kamaji that referenced this pull request Apr 22, 2024
@kvaps
feat: allow overriding secretKey for kubeconfig
eb42e0e 
During reconciliation, the control plane provider copies the content from the secret provided by
Kamaji, named <cluster>-admin-kubeconfig, into a generic Cluster API secret, <cluster>-kubeconfig,
which can then be used by the bootstrap provider and other cluster components.

This change introduces a new annotation, kamaji.clastix.io/kubeconfig-secret-key, for the
KamajiControlPlane resource. This annotation instructs the control plane provider to read the
kubeconfig from a specific key (the default one is admin.conf).

Example:

```
kamaji.clastix.io/kubeconfig-secret-key: admin.svc
```

This will instruct the system to use `admin.svc` a kubeconfig with a local service FQDN
(introduced by clastix/kamaji#403).

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
1 participant
@prometherion