Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default konnectivity version #492

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Jul 16, 2024

With the EOL of 1.27, apiserver-network-proxy installation should use the minor versions of their cluster's version.
So the recommended konnectivity version for a 1.29.X Kubernetes cluster is 0.29.Y.

See: https://github.com/kubernetes-sigs/apiserver-network-proxy?tab=readme-ov-file#versioning-and-releases

Increase the default version for konnectivity to v0.28.6, which corresponds to the next EOL Kubernetes minor version.

Signed-off-by: Mario Valderrama <mario.valderrama@ionos.com>
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for kamaji-documentation ready!

Name Link
🔨 Latest commit 841a8b9
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/6696df0cf131f1000852f37c
😎 Deploy Preview https://deploy-preview-492--kamaji-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@avorima avorima marked this pull request as ready for review July 16, 2024 21:19
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching up, it would be cool if we could automatically determine the Konnectivity version according to the Kubernetes one unless the user specifies one.

We could address this in a different PR, thanks anyway for bumping up!

@prometherion prometherion merged commit 84e6693 into clastix:master Jul 17, 2024
10 checks passed
@avorima avorima deleted the update-konnectivity branch July 17, 2024 09:37
@avorima
Copy link
Contributor Author

avorima commented Jul 17, 2024

Thanks for catching up, it would be cool if we could automatically determine the Konnectivity version according to the Kubernetes one unless the user specifies one.

We could address this in a different PR, thanks anyway for bumping up!

Yes, I was thinking the same thing. A simple default would be using v0.29.0 for v1.29.X, v0.30.0 for v1.30.X and so on.

@prometherion
Copy link
Member

Thanks, tracking a future request with #494.

@prometherion prometherion added the enhancement New feature or request label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants