Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default datastore name in the helm chart #536

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

bsctl
Copy link
Member

@bsctl bsctl commented Aug 11, 2024

close #535

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 9983b6b
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/66b9b511e7e34c00083bb176

@bsctl
Copy link
Member Author

bsctl commented Aug 11, 2024

@prometherion always have issues on helm-docs. I always run helm-docs before to push but CI still complains about it:

 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | affinity | object | `{}` | Kubernetes affinity rules to apply to Kamaji controller pods |
-| defaultDatastoreName | string | `"default"` | Specify the default DataStore name for the Kamaji instance. |
+| defaultDatastoreName | string | `"default"` | (string) Specify the default DataStore name for the Kamaji instance. |

Just noted the CI uses helm-docs 1.8 while on my machine there is the 1.11

helm-docs --version
helm-docs version 1.11.0 

@prometherion prometherion marked this pull request as ready for review August 12, 2024 07:13
@prometherion prometherion merged commit d8a86ed into master Aug 12, 2024
10 checks passed
@prometherion prometherion deleted the issues/535 branch August 12, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logic for default datastore
2 participants