Added support for {{<directive>}} directives such as table of contents. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't want to step on anyone's toes.. I just saw a PR for TOC as well. Thought this way might allow for future flexibility as well as plugging in third party packages. |
|
No problem, it's just funny that after I had the "TOC" issue open for... ever? now two PR came in almost at the same time fixing it :) Regarding the directive thing, I think it's a cool idea. I will take a look at it (testing and adding doc if needed) asap... unfortunately at the moment we are very busy releasing a product for December, which means I need to work on weekend too. Have patience. Thanks! |
|
Cool, thanks! No rush obviously :) |
claudioc
added a commit
that referenced
this pull request
Dec 13, 2015
Added support for {{<directive>}} directives such as table of contents.
This was referenced Dec 13, 2015
Closed
claudioc
added a commit
that referenced
this pull request
Dec 13, 2015
- Adds the ability to revert to a specific revision from the history page (@brad7928) - Adds support for directives (see PR #115) (@creynold) - Adds support for Table of Contents (@creynold and @brad7928) - Adds a new `emptyEmailMatches` configuration parameter (see README) - Added the /etc configuration directory (for useful configurations we may need) - Fixes #110 (@brad7928) - Fixes #109 - Fixes #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function
applyDirectiveswhich looks for{{.*}}including newlines. It then replaces the{{.*}}match with the return of functions fromdirectives.js. As an example:If the wiki text is:
Then
applyDirectiveswill pass the full text of the wiki andA->B: somethingrespectively to the functiondirectives.directiveMap.sequence. The return of this function will replace the braced text.