Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple java modules in exist.xml #7

Closed
dizzzz opened this issue Jan 7, 2018 · 9 comments
Closed

Allow multiple java modules in exist.xml #7

dizzzz opened this issue Jan 7, 2018 · 9 comments
Assignees

Comments

@dizzzz
Copy link
Contributor

dizzzz commented Jan 7, 2018

See eXist-db/exist-apps-archetype#4

according to 'the spec' the following is allowed in exist.xml but is not (yet) supported by the plugin:

<?xml version="1.0" encoding="UTF-8"?>
<package xmlns="http://exist-db.org/ns/expath-pkg">
    <jar>exist-mongrel-@VERSION@.jar</jar>
    <jar>mongodb-driver-3.4.2.jar</jar>
    <jar>mongodb-driver-core-3.4.2.jar</jar>
    <jar>bson-3.4.2.jar</jar>
    <java>
        <namespace>http://expath.org/ns/mongo</namespace>
        <class>org.exist.mongodb.xquery.MongodbModule</class>
    </java>
    <java>
        <namespace>http://expath.org/ns/mongo/gridfs</namespace>
        <class>org.exist.mongodb.xquery.GridfsModule</class>
    </java>
</package>
@dizzzz dizzzz changed the title Allow multiple java modules Allow multiple java modules in exist.xml Jan 7, 2018
@claudius108 claudius108 self-assigned this Jan 7, 2018
claudius108 added a commit that referenced this issue Jan 9, 2018
claudius108 added a commit that referenced this issue Jan 9, 2018
@claudius108
Copy link
Owner

claudius108 commented Jan 9, 2018

@fixed in version 0.5.3, which I am now trying to release.

The syntax is as follows:

<package>
        ...
	<components>
		<resource>
			<public-uri>http://expath.org/ns/mongo</public-uri>
			<file>org.exist.mongodb.xquery.MongodbModule</file>
		</resource>
		<resource>
			<public-uri>http://expath.org/ns/mongo/gridfs</public-uri>
			<file>org.exist.mongodb.xquery.GridfsModule</file>
		</resource>
	</components>
</package>

@dizzzz
Copy link
Contributor Author

dizzzz commented Jan 9, 2018

looks good and usable to me!

<package> 
    ... 
    <components>
        <resource>
            <public-uri>http://expath.org/ns/mongo</public-uri>
            <file>org.exist.mongodb.xquery.MongodbModule</file>
        </resource>
        <resource>
            <public-uri>http://expath.org/ns/mongo/gridfs</public-uri>
            <file>org.exist.mongodb.xquery.GridfsModule</file>
        </resource>
    </components>
</package>

@claudius108
Copy link
Owner

Hm, how?

@dizzzz
Copy link
Contributor Author

dizzzz commented Jan 9, 2018

I meant: I see the way of defining multiple sets (uri-file) ....
Maybe it is better to call it a bit different like

        <resource>
            <module-namespace>http://expath.org/ns/mongo</public-uri>
            <java-class>org.exist.mongodb.xquery.MongodbModule</file>
        </resource>

?

@claudius108
Copy link
Owner

No, how did you wrote indented XML?

The above syntax I mentioned is EXPath Package-like. I will change the other syntaxes, too, in the future, to be EXPath Package-like.

@dizzzz
Copy link
Contributor Author

dizzzz commented Jan 9, 2018

ahhhhh, ok.
allow_multiple_java_modules_in_exist_xml_ issue__7 _claudius108_kuberam-expath-plugin

works for: java, xml,xquery,....

@claudius108
Copy link
Owner

claudius108 commented Jan 10, 2018

Great, thanks.

So, I just released version 0.5.4, which should fix this.

@dizzzz
Copy link
Contributor Author

dizzzz commented Jan 10, 2018

fyi..... below the the text box is a manual I see right now: https://guides.github.com/features/mastering-markdown/

@claudius108
Copy link
Owner

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants