Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not compile with go 1.3 (so you said) #3

Closed
arnonym opened this issue Aug 27, 2014 · 7 comments
Closed

Does not compile with go 1.3 (so you said) #3

arnonym opened this issue Aug 27, 2014 · 7 comments
Assignees
@clausecker
Labels
bug

Comments

@arnonym
Copy link

arnonym commented Aug 27, 2014

go get github.com/fuzxxl/nfc/1.0/nfc

src/github.com/fuzxxl/nfc/1.0/nfc/nfc.go:205: undefined: context
@clausecker clausecker added the bug label Aug 27, 2014
@clausecker clausecker self-assigned this Aug 27, 2014
@clausecker
Copy link
Owner

I have an operation plan for now. This plan will involve backwards-incompatible API changes in the XxxTarget types. If you're writing stuff against these types, please put that on hold while I fix the code.

clausecker added a commit that referenced this issue Aug 29, 2014
@clausecker
Make code compile (fix issue #3, makes issue #1 obsolete)
7fd106e 
This commit contains a complete reimplementation of the marshalling code
which is now done mostly in C code. I use a dirty hack to get around the
inability to access Go types from C code in my code, see commentary in
marshall.h for more details.
@clausecker
Copy link
Owner

@arnonym Please check if github.com/fuzxxl/nfc/dev/nfc compiles. I will prepare a release shortly after.

@arnonym
Copy link
Author

arnonym commented Aug 29, 2014

pi@raspberrypi ~/gide $ go get github.com/fuzxxl/nfc/dev/nfc

github.com/fuzxxl/nfc/dev/nfc

src/github.com/fuzxxl/nfc/dev/nfc/nfc.go:205: undefined: context

Unfortunately no change.

@clausecker
Copy link
Owner

Can you tell me the output of go version?

@clausecker
Copy link
Owner

Also, you should try running go get -u github.com/fuzxxl/nfc/dev/nfc. It might be possible that youdidn't update the code.

@arnonym
Copy link
Author

arnonym commented Aug 30, 2014

After upgrading to go 1.3 the library compiles. Thank you! I will try to interface with my PN532 later. I'll keep you updated.

@clausecker
Copy link
Owner

Okay. I will prepare another release (2.0) later on. I try to iron out some oddities in the API before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clausecker clausecker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnonym @clausecker