Revert to BoundaryNorm if TwoSlopeNorm not found #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In add_colormaps, the improved version doesn't work with older versions of matplotlib.
mandli
reviewed
Jun 4, 2020
| norm = colors.TwoSlopeNorm(data_break, data_limits[0], data_limits[1]) | ||
| except: | ||
| # older matplotlib.colors did not have TwoSlopeNorm, revert to old: | ||
| norm = colors.BoundaryNorm(boundaries=bounds, ncolors=N) |
There was a problem hiding this comment.
Might be good to catch only the specific error, whatever that was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In add_colormaps, the improved version doesn't work with older versions of
matplotlib.