Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow pretty and output args #5

Merged
merged 2 commits into from
Feb 27, 2018
Merged

allow pretty and output args #5

merged 2 commits into from
Feb 27, 2018

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented Feb 26, 2018 •
edited
Loading

  • allows pretty arg, enables pretty-printing for situations when end user cannot rely on global env variable
  • allows output arg, useful for piping output to stderr instead of stdout
  • refactored some of the init function to reduce complexity

@nelsonpecora nelsonpecora mentioned this pull request Feb 26, 2018
Closed
cperryk
cperryk suggested changes Feb 26, 2018
View reviewed changes
Copy link

@cperryk cperryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you update the README to reflect this?

@nelsonpecora
Copy link
Contributor Author

good point, updating

@nelsonpecora nelsonpecora merged commit c33dbff into master Feb 27, 2018
@nelsonpecora nelsonpecora deleted the args branch February 27, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperryk cperryk cperryk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonpecora @cperryk