Streamlined package #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR
- refactors `Tokenizer`
- such that `Profile` and `Rules` become separate objects, which makes
initialization more modular,
- adds some configurability of input and output,
- unifies `tokenize` and `tokenize_ipa` into a single method, implemented
in `__call__` (because tokenizing seems to be the default thing to do
for a Tokenizer).
- adds a cli, with two sub-commands `tokenize` and `profile`
closes cldf#1
|
Thanks for merging - hope you are not frustrated by my ever-changing views of what API is best :) |
|
Not at all -- sorry for the slow merge (was returning to Z). Mattis is here now, so it was a good time to look it over and discuss next topics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
TokenizerProfileandRulesbecome separate objects, which makesinitialization more modular,
tokenizeandtokenize_ipainto a single method, implementedin
__call__(because tokenizing seems to be the default thing to dofor a Tokenizer).
tokenizeandprofilecloses #1