Fixes #476 - keep import on top when restructuring #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -634,6 +634,10 @@ AdvancedOptimizer.prototype.restructure = function (tokens) { | |||
|
|
|||
| var position = tokens[0] && tokens[0].kind == 'at-rule' && tokens[0].value.indexOf('@charset') === 0 ? 1 : 0; | |||
| for (; position < tokens.length - 1; position++) { | |||
| if (!tokens[position] || tokens[position].kind != 'at-rule' || tokens[position].value.indexOf('@import') !== 0) | |||
There was a problem hiding this comment.
@buduchail can we do it in one step together with checking for comments? Otherwise 💯
There was a problem hiding this comment.
I have combined the two checks together now. Thanks!
|
@buduchail I've merged it manually simplifying the checks - the credit still goes to you! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem when minimizing CSS with optimizations on but processing of import rules off. Some optimized selectors would end up above import rules, thus ignoring imported fonts in the generated CSS. This change fixes the problem in our environment.