Bugfix: IssueManager.get_summary() -> make_summary() in custom issue manager example #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to add some sort of unit test for this
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 46 46
Lines 3638 3639 +1
Branches 649 649
=======================================
+ Hits 3485 3486 +1
Misses 79 79
Partials 74 74
|
- Validate scores provided to IssueManager.make_summary - Move fixture for custom issue manager to conftest.py - Test make_summary on a "custom" IssueManager
|
More unit tests added in eeb215d |
|
Failing tests in CI are unrelated. |
elisno
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add some sort of unit test for this @elisno