Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception Handling for Vault #16

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Exception Handling for Vault #16

merged 5 commits into from
Jun 15, 2021

Conversation

Vishesh-Gupta
Copy link
Contributor

  • Better README for Vault changes
  • Exceptions raised properly
  • Exceptions Handled properly
  • Testing made more robust

@Vishesh-Gupta Vishesh-Gupta self-assigned this Jun 10, 2021
@Vishesh-Gupta Vishesh-Gupta added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 10, 2021
@tanishq-dubey
Copy link
Contributor

Also need to make a setup.py change for versioning

@tanishq-dubey tanishq-dubey merged commit b35324e into clear-street:master Jun 15, 2021
@Vishesh-Gupta Vishesh-Gupta deleted the robust-tests-and-fixes branch June 17, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanishq-dubey tanishq-dubey tanishq-dubey approved these changes

@john-delivuk john-delivuk john-delivuk approved these changes

Assignees

@Vishesh-Gupta Vishesh-Gupta

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vishesh-Gupta @tanishq-dubey @john-delivuk