Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method eckey_to_public #12

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Remove method eckey_to_public #12

merged 7 commits into from
Sep 5, 2023

Conversation

cbobach
Copy link
Contributor

@cbobach cbobach commented Sep 1, 2023

As part of our migration to Ruby 3.1 we need to ensure that this gem supports it.

The OpenSSL library has tightened the mutability on objects.

Supported Ruby versions should now be 2.7, 3.0, 3.1 and 3.2

lib/aliquot-pay.rb Outdated Show resolved Hide resolved
@mt-clearhaus
Copy link
Contributor

mt-clearhaus commented Sep 4, 2023

The contents of this PR has ended up primarily being the removal of eckey_to_public rather than a migration to Ruby 3.1 because the gem was already able to run with Ruby 3.1. Perhaps the PR should be renamed, or it should be closed in favor of a new PR?

lib/aliquot-pay.rb Outdated Show resolved Hide resolved
@cbobach
Copy link
Contributor Author

cbobach commented Sep 4, 2023

Regarding the naming I agree with you, I think this was because I came from looking at aliquot which required this repo to be updated first 😄 I'll rename 👍

@cbobach cbobach changed the title Ensure that alliquot-pay can run on Ruby 3.1 Remove method eckey_to_public Sep 4, 2023
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👍

@cbobach cbobach merged commit d055228 into master Sep 5, 2023
4 checks passed
@cbobach cbobach deleted the migrate-to-ruby-3.1 branch September 5, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants