Add support for custom subpackage requires #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryteise
force-pushed
the
manual-subpackage-requires
branch
from
6fe0856
to
6d5185a
Compare
Due to more systems being added for automated runtime dependency injection for subpackages, we need a way for manual overrides of the default detected dependencies. This change provides support for specifying which subpackage runtime dependencies should be added or removed and consolidates some of the custom configuration file detection along with it.
|
@bryteise I just tested the code with flake8-3.8.0a2 (and pycodestyle-2.6.0a1), and no issues are identified with your changes. There are 4 new issues raised, but I'll address those in a different PR. Proceeding with review... |
phmccarty
reviewed
Apr 24, 2020
The content map can never be empty at this point due to the assignment so remove the test. We could have checked the files element in the map to see if it was empty but printing a warning for an empty extras file isn't very valuable.
phmccarty
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to more systems being added for automated runtime dependency
injection for subpackages, we need a way for manual overrides of the
default detected dependencies.
This change provides support for specifying which subpackage runtime
dependencies should be added or removed and consolidates some of the
custom configuration file detection along with it.