Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm] Should we use stable identifier for kubernetes version #13

Closed
krsna1729 opened this issue Dec 7, 2018 · 5 comments
Closed

Comments

@krsna1729
Copy link
Contributor

Instead of pinning the dot version kubernetesVersion: v1.12.0 is it better to use kubernetesVersion: stable-1.12 ?

@krsna1729
Copy link
Contributor Author

@mcastelino

@fenrus75
Copy link

fenrus75 commented Dec 7, 2018 via email

@mcastelino
Copy link
Contributor

@fenrus75 @krsna1729 we should not need to pin. These files are included as part of the cloud-native-basic bundle. So they will/should rev whenever any kubernetes or CNI or CRI artifacts rev. So if the scripts break when we update cloud-native-bundle we need to fix the scripts. So when the user upgrades the scripts update. The user should never use files from this repo directly. They should always used the files that came with the bundle itself.

@mcastelino
Copy link
Contributor

@krsna1729 with this change #14 we can close this right?

@krsna1729
Copy link
Contributor Author

krsna1729 commented Dec 7, 2018

@mcastelino yes. I should have used the closes keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants