Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimeClass updates for kubernetes 1.14 #80

Merged

Conversation

egernst
Copy link
Contributor

@egernst egernst commented Mar 28, 2019

RuntimeClass moved from alpha to beta. Remove the feature gates, remove
the runtimeClass CRD since it is a built in type, and take the new data
structure into account.

Signed-off-by: Eric Ernst eric.ernst@intel.com

@egernst
Copy link
Contributor Author

egernst commented Mar 28, 2019

/cc @krsna1729 @mcastelino

@egernst egernst force-pushed the k8s-1.14-runtimeclass-updates branch from bba6df9 to 390341b Compare March 28, 2019 03:07
RuntimeClass moved from alpha to beta. Remove the feature gates, remove
the runtimeClass CRD since it is a built in type, and take the new data
structure into account.

Fixes: clearlinux#77

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Copy link
Contributor

@krsna1729 krsna1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krsna1729
Copy link
Contributor

@hnanni please take a look at this PR. Test with in-house clear versions.
Resolves: #77

Copy link

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And just ran into this this morning (note, minikube has updated to 1.14...)
lgtm!

@krsna1729
Copy link
Contributor

Waiting on clear

@mythi
Copy link
Contributor

mythi commented Apr 1, 2019

Waiting on clear

Is this being worked on?

@krsna1729
Copy link
Contributor

@mythi we are waiting on clear push out 1.14. Once there we can test and merge these 1.14 specific PR.

@krsna1729
Copy link
Contributor

/cc @bryteise @hnanni

@ganeshmaharaj
Copy link
Contributor

ganeshmaharaj commented Apr 1, 2019 via email

@hnanni hnanni mentioned this pull request Apr 1, 2019
@hnanni
Copy link

hnanni commented Apr 1, 2019

Thanks, kubeadm init --config=./kubeadm.yaml completed:
Your Kubernetes control-plane has initialized successfully!

I'm holding the push of 1.14 to the CLR repository until the internal test of k8s (based on cloud-native-setup scripts) is ready. After the fix this PR provides, the current issue/error is that kubeadm join is failing ( #83 )

@ganeshmaharaj
Copy link
Contributor

@hnanni how goes the update of clear to 1.14 packages for k8s? I have a cri-o updates to match k8s, but holding off until we get the k8s version in.

@hnanni
Copy link

hnanni commented Apr 3, 2019

@ganeshmaharaj Find k8s 1.14 in the just released CLR 28630 version. I've tested it with #80.

@ganeshmaharaj
Copy link
Contributor

@hnanni That's awesome. can we merge this patch then? I will upstream the cri-o update today.

@hnanni
Copy link

hnanni commented Apr 3, 2019

yes, please merge #80

@ganeshmaharaj ganeshmaharaj merged commit f863bb7 into clearlinux:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants