-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtimeClass updates for kubernetes 1.14 #80
runtimeClass updates for kubernetes 1.14 #80
Conversation
bba6df9
to
390341b
Compare
RuntimeClass moved from alpha to beta. Remove the feature gates, remove the runtimeClass CRD since it is a built in type, and take the new data structure into account. Fixes: clearlinux#77 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And just ran into this this morning (note, minikube has updated to 1.14...)
lgtm!
Waiting on clear |
Is this being worked on? |
@mythi we are waiting on clear push out 1.14. Once there we can test and merge these 1.14 specific PR. |
Working on it. Will have clear updated to 1.14 for k8s soon.
…On Mon, Apr 1, 2019, 7:58 AM Saikrishna Edupuganti ***@***.***> wrote:
/cc @bryteise <https://github.com/bryteise> @hnanni
<https://github.com/hnanni>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFSZuo8NdgnFqE-hU5KyYX4OJrpfqXi8ks5vch6MgaJpZM4cPMO->
.
|
Thanks, I'm holding the push of 1.14 to the CLR repository until the internal test of k8s (based on cloud-native-setup scripts) is ready. After the fix this PR provides, the current issue/error is that |
@hnanni how goes the update of clear to 1.14 packages for k8s? I have a cri-o updates to match k8s, but holding off until we get the k8s version in. |
@ganeshmaharaj Find k8s 1.14 in the just released CLR 28630 version. I've tested it with #80. |
@hnanni That's awesome. can we merge this patch then? I will upstream the cri-o update today. |
yes, please merge #80 |
RuntimeClass moved from alpha to beta. Remove the feature gates, remove
the runtimeClass CRD since it is a built in type, and take the new data
structure into account.
Signed-off-by: Eric Ernst eric.ernst@intel.com