Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underflow fix #171

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Underflow fix #171

merged 3 commits into from
Mar 23, 2020

Conversation

AntoineRondelet
Copy link
Contributor

Quick fix for #170

@AntoineRondelet AntoineRondelet changed the base branch from master to develop March 18, 2020 15:35
dtebbs
dtebbs reviewed Mar 18, 2020
View reviewed changes
src/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
dtebbs
dtebbs reviewed Mar 18, 2020
View reviewed changes
src/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
dtebbs
dtebbs reviewed Mar 18, 2020
View reviewed changes
src/circuits/joinsplit.tcc Outdated Show resolved Hide resolved
rrtoledo
rrtoledo approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@rrtoledo rrtoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could perhaps add a warning if b < a in safe_substraction

@AntoineRondelet AntoineRondelet mentioned this pull request Mar 23, 2020
Open
@AntoineRondelet AntoineRondelet merged commit 593e22f into develop Mar 23, 2020
@AntoineRondelet AntoineRondelet deleted the underflow-fix branch March 26, 2020 14:50
AntoineRondelet added a commit that referenced this pull request May 6, 2020
@AntoineRondelet
Merge pull request #171 from clearmatics/underflow-fix
b091e4f 
Underflow fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrtoledo rrtoledo rrtoledo approved these changes

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoineRondelet @dtebbs @rrtoledo