Removed google duplicated dependency #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineRondelet
requested review from
dtebbs
and removed request for
AntoineRondelet
dtebbs
force-pushed
the
fix-dep-duplicated
branch
from
7cb83d6
to
bfc48d8
Compare
|
Rebased this onto |
|
Our submodule import of googletest seems not to be used in any of our cmake files - we use the definitions coming from the libsnark / libfqfft. This change harmlessly removes our submodule. |
dtebbs
approved these changes
Dec 10, 2019
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
Removed google duplicated dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #10
In case the dependency has been initialized the user will see a
depends/googletest untrackedfolder that has to delete manually.https://gist.github.com/myusuf3/7f645819ded92bda6677