Update web3 and pylint packages in client (depends on #388) #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
changed the title
dtebbs
force-pushed
the
update-web3
branch
2 times, most recently
from
375c56b
to
5fb1002
Compare
dtebbs
changed the title
|
Changes are complete (removing WIP and requesting review) , but keeping as draft until other PRs are merged. |
AntoineRondelet
approved these changes
Aug 17, 2021
dtebbs
force-pushed
the
update-libsnark
branch
from
7fa90d6
to
3c9c86d
Compare
dtebbs
force-pushed
the
update-libsnark
branch
from
3c9c86d
to
edf0caa
Compare
AntoineRondelet
added a commit
that referenced
this pull request
Aug 20, 2021
Remove hardcoded gas (depends on #389)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web3.py update did not really eliminate as much code as I had hoped. They provide some better interfaces for parsing log data, so we avoid importing a few undocumented functions, but unless I'm missing something it's still not easy to iterate through a list of logs, filtering them by name (without jupming through some hoops or making multiple requests to the node).
A new minor version of pylint (which got dragged in when I relaxed some version conditions as part of the web3.py udpate) seems a bit stricter about import formats.