Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update last publish time adding period #62

Merged
merged 1 commit into from
May 6, 2020

Conversation

efernandez
Copy link
Member

This change is important so we don't ignore the offset between the expected and actual publish time. Otherwise, frequencies that aren't a multiple of the control frequency can never be achieved.

Indeed, this changes makes things match the implementation in the joint_state_controller, that is working as intended:
https://github.com/ros-controls/ros_controllers/blob/12a70baee38bf198ad434ad704b353621b23c61a/joint_state_controller/src/joint_state_controller.cpp#L86

@efernandez efernandez added the bug label May 5, 2020
@efernandez efernandez self-assigned this May 5, 2020
@efernandez efernandez merged commit 38e474f into indigo-devel May 6, 2020
@efernandez efernandez deleted the fix-last-publish-time branch May 6, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants