Make lookup of authorization header value case insensitive #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebert
reviewed
Jul 6, 2020
robrat
force-pushed
the
fix/authorization-header-name
branch
from
de27618
to
6cb9249
Compare
clebert
requested changes
Jul 6, 2020
robrat
force-pushed
the
fix/authorization-header-name
branch
from
6cb9249
to
cf67770
Compare
clebert
requested changes
Jul 7, 2020
clebert
changed the title
robrat
force-pushed
the
fix/authorization-header-name
branch
2 times, most recently
from
f7f8326
to
c3aea18
Compare
clebert
requested changes
Jul 7, 2020
- getHeaderValue() cannot be moved to cdk/utils because it is not bundled - added authorizer to jest coveragePathIgnorePatterns as advised in pull request discussion
robrat
force-pushed
the
fix/authorization-header-name
branch
from
c3aea18
to
37ae32d
Compare
clebert
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some setups pass the basic auth header with first letter in upper case, so also check for this value