1.0.alpha.4 (Sourcery refactored) #214
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.10%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
👇 Click on the image for a new way to code review
Legend |
Codecov ReportBase: 92.94% // Head: 92.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #214 +/- ##
===========================================
+ Coverage 92.94% 92.97% +0.03%
===========================================
Files 26 26
Lines 4421 4414 -7
===========================================
- Hits 4109 4104 -5
+ Misses 312 310 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sourcery-ai
bot
force-pushed
the
sourcery/develop
branch
from
d9862aa
to
48673e1
Compare
| if self._timestamp is not None: | ||
| return self._timestamp.timestamp | ||
| return None | ||
| return self._timestamp.timestamp if self._timestamp is not None else None |
There was a problem hiding this comment.
Function TimeMixin.time_stamp refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if self._timespan is not None: | ||
| return self._timespan.begin | ||
| return None | ||
| return self._timespan.begin if self._timespan is not None else None |
There was a problem hiding this comment.
Function TimeMixin.begin refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if self._timespan is not None: | ||
| return self._timespan.end | ||
| return None | ||
| return self._timespan.end if self._timespan is not None else None |
There was a problem hiding this comment.
Function TimeMixin.end refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
| if mode in ("relativeToGround", "clampToGround", "absolute"): | ||
| self._altitude_mode = str(mode) | ||
| if mode in {"relativeToGround", "clampToGround", "absolute"}: | ||
| self._altitude_mode = mode |
There was a problem hiding this comment.
Function _AbstractView.altitude_mode refactored with the following changes:
- Use set when checking membership of a collection of literals (
collection-into-set) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
| if altitude_mode is not None: | ||
| self.altitude_mode = altitude_mode.text | ||
| else: | ||
| if altitude_mode is None: | ||
| altitude_mode = element.find(f"{gx.NS}altitudeMode") | ||
| self.altitude_mode = altitude_mode.text | ||
| self.altitude_mode = altitude_mode.text |
There was a problem hiding this comment.
Function _AbstractView.from_element refactored with the following changes:
- Swap if/else to remove empty if body (
remove-pass-body) - Hoist repeated code outside conditional statement (
hoist-statement-from-if)
Pull Request #213 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
developbranch, then run:Help us improve this pull request!