Release 1.0.alpha.6 (Sourcery refactored) #248

sourcery-ai · 2023-10-16T11:25:26Z

Pull Request #246 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the develop branch, then run:

git fetch origin sourcery/develop
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

watermelon-copilot-for-code-review · 2023-10-16T11:25:30Z

Please login to Watermelon to see the results

what-the-diff · 2023-10-16T11:26:01Z

PR Summary

Enhanced Geometry Property Handling
In fastkml/kml.py, we improved how the geometry property operates. Now, if geometry has a valid value, it's returned; if it's not assigned, it would return None. This might improve how our code handles uncertain or missing values.
Improved Boolean Function
In fastkml/styles.py, we made a change to the strtobool function. It now converts "true" to 1 and any other input into an integer form of the value after converting it to a float first. This can increase the accuracy of our operations involving boolean values.
Stricter Element Validation
Also in fastkml/styles.py, we've added rigorous checks to the from_element method. It will now throw a ValueError if the key element doesn't meet the required criteria ("highlight" or "normal"). This ensures that only valid input values are processed, adding a layer of data integrity.
Adjusted Test Method
In our tests/base_test.py, we've adjusted the test_base_from_element_raises method. Now, it uses the config.KMLNS value to create the element variable. This adjustment can help us ensure more accurate testing situations.

ghost · 2023-10-16T11:27:43Z

👇 Click on the image for a new way to code review

Legend

codecov · 2023-10-16T11:28:35Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b773b94) 93.18% compared to head (b071191) 93.24%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
+ Coverage    93.18%   93.24%   +0.05%     
===========================================
  Files           33       33              
  Lines         4787     4781       -6     
===========================================
- Hits          4461     4458       -3     
+ Misses         326      323       -3

Files	Coverage Δ
fastkml/kml.py	`78.17% <100.00%> (+0.05%)`	⬆️
fastkml/styles.py	`95.94% <100.00%> (+0.61%)`	⬆️
tests/base_test.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

watermelon-copilot-for-code-review · 2023-10-16T12:42:44Z

Please login to Watermelon to see the results

watermelon-copilot-for-code-review · 2023-10-16T12:57:20Z

Please login to Watermelon to see the results

watermelon-copilot-for-code-review · 2023-10-16T13:37:12Z

Please login to Watermelon to see the results

watermelon-copilot-for-code-review · 2023-10-16T13:44:23Z

Please login to Watermelon to see the results

sourcery-ai · 2023-10-16T13:44:26Z

fastkml/kml.py

-        if self._geometry is not None:
-            return self._geometry.geometry
-        return None
+        return self._geometry.geometry if self._geometry is not None else None


Function Placemark.geometry refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-10-16T13:44:26Z

fastkml/styles.py

-            if val == "true":
-                return 1
-            return int(float(val))
+            return 1 if val == "true" else int(float(val))


Function PolyStyle.from_element refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-10-16T13:44:26Z

fastkml/styles.py

-            if key is None:
+            if key is None or key.text not in ["highlight", "normal"]:


Function StyleMap.from_element refactored with the following changes:

Merge duplicate blocks in conditional (merge-duplicate-blocks)

Remove redundant conditional [×2] (remove-redundant-if)

Replace multiple comparisons of same variable with in operator (merge-comparisons)

sourcery-ai · 2023-10-16T13:44:26Z

tests/base_test.py

-        element = cast(
-            types.Element,
-            config.etree.Element(config.KMLNS + "Base"),  # type: ignore[attr-defined]
-        )
+        element = cast(types.Element, config.etree.Element(f"{config.KMLNS}Base"))


Function TestStdLibrary.test_base_from_element_raises refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

# type: ignore[attr-defined]

sourcery-ai bot force-pushed the sourcery/develop branch from 038f857 to de5c949 Compare October 16, 2023 11:25

sourcery-ai bot requested a review from cleder October 16, 2023 11:25

sourcery-ai bot force-pushed the sourcery/develop branch from de5c949 to cf0019f Compare October 16, 2023 12:42

sourcery-ai bot force-pushed the sourcery/develop branch from cf0019f to 856bb3a Compare October 16, 2023 12:57

sourcery-ai bot changed the title ~~Release 1.0.alpha.5 (Sourcery refactored)~~ Release 1.0.alpha.6 (Sourcery refactored) Oct 16, 2023

sourcery-ai bot force-pushed the sourcery/develop branch from 856bb3a to 10a3aa3 Compare October 16, 2023 13:37

'Refactored by Sourcery'

b071191

sourcery-ai bot force-pushed the sourcery/develop branch from 10a3aa3 to b071191 Compare October 16, 2023 13:44

sourcery-ai bot commented Oct 16, 2023

View reviewed changes

sourcery-ai bot closed this Oct 16, 2023

sourcery-ai bot deleted the sourcery/develop branch October 16, 2023 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.0.alpha.6 (Sourcery refactored) #248

Release 1.0.alpha.6 (Sourcery refactored) #248

sourcery-ai bot commented Oct 16, 2023 •

edited

Loading

watermelon-copilot-for-code-review bot commented Oct 16, 2023

what-the-diff bot commented Oct 16, 2023

ghost commented Oct 16, 2023 •

edited by ghost

Loading

Legend

codecov bot commented Oct 16, 2023 •

edited

Loading

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

sourcery-ai bot Oct 16, 2023

sourcery-ai bot Oct 16, 2023

sourcery-ai bot Oct 16, 2023

sourcery-ai bot Oct 16, 2023

		if key is None:
		if key is None or key.text not in ["highlight", "normal"]:

Release 1.0.alpha.6 (Sourcery refactored) #248

Release 1.0.alpha.6 (Sourcery refactored) #248

Conversation

sourcery-ai bot commented Oct 16, 2023 • edited Loading

watermelon-copilot-for-code-review bot commented Oct 16, 2023

what-the-diff bot commented Oct 16, 2023

PR Summary

ghost commented Oct 16, 2023 • edited by ghost Loading

Legend

codecov bot commented Oct 16, 2023 • edited Loading

Codecov Report

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

watermelon-copilot-for-code-review bot commented Oct 16, 2023

sourcery-ai bot Oct 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Oct 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Oct 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot Oct 16, 2023

Choose a reason for hiding this comment

sourcery-ai bot commented Oct 16, 2023 •

edited

Loading

ghost commented Oct 16, 2023 •

edited by ghost

Loading

codecov bot commented Oct 16, 2023 •

edited

Loading