Added Debug and Xray npm packages.

[ciscoheat]

Two pretty useful packages. Debug is nice and simple: https://www.npmjs.com/package/debug

X-ray is more advanced, and I had to create a separate version of the request driver it uses, I hope that's ok.

Finally, since both packages uses a function with properties, I'm using an abstract for the implementation. The @:callable metadata makes it possible, with that it's possible to call the underlying function directly. Nice stuff!

[ciscoheat]

I'm about to add one more package to this one, brb

[clemos]

I was reviewing this PR, trying to figure a way to simplify it if possible...

[ciscoheat]

Great if you can, I've tried a couple of things but couldn't make it better than this. The problem is how to call properties on a function. (That abstract solves quite nice, imo)

[clemos]

Off the top of my head, regarding debug, I think something like that might be better / simpler (not even sure if it works):

extern class Debug
implements npm.Package.Require<"debug","^2.2.0">
{
   @:selfCall
   public function new(name:String):Void;
   // special function
   public inline function call( data : Dynamic, ?infos : haxe.PosInfos ) {
      var args = [data];
      if( infos != null && infos.customParams != null ) {
          args = args.concat( infos.customParams );
      }
      untyped this.apply( this, args );
   }

   // not sure about this one, but why not
   // it could make it possible to `debug.log = haxe.Log.trace`
   public var log: Dynamic -> ?haxe.PosInfos -> Void;
}

See http://old.haxe.org/doc/cross/trace

What do you think ?

[ciscoheat]

I'll take a look!

[ciscoheat]

Now I remember, there is a static log var on the Debug class as well, that's why the solution is a bit more complicated.

[clemos]

Sorry, misclicked

[ciscoheat]

Just commited a version that supports haxe.Log.trace in both directions. Thanks for the suggestion!

[ciscoheat]

Expanded the Jade class now, and added the Commonmark markdown package.

[clemos]

I don't think you need inline or this trick, do you ?

[ciscoheat]

I wish it was that simple. There are many things that should be fulfilled here:

1. Easy instantiation: var debug = new Debug("myapp")
2. Easy usage: debug("Working")
3. Easy configuration: debug.log(haxe.Log.trace)
4. Easy static configuration: Debug.log(someOtherLog)

It seems not possible to fulfill all these at the same time. If I use construct and an abstract class, 2-4 can be fulfilled, keeping as close to the original API as possible.

[clemos]

All 4 should be possible without inline, since Debug and DebugInstance are two different classes, shouldn't it ?

[ciscoheat]

So, any chance to get this pulled in? :)

[clemos]

I'm not too much in favor of adding logic in externs :S

[clemos]

Sorry for the delay; I just added more comments :S

[ciscoheat]

I can remove the XrayHttpDriver, no problem. But I cannot see, in both the case of xray and debug, how to make an extern that can call itself directly? @:selfCall is a solution, but then you need to call a method on the object, and what name should that method have, compared to just calling it (with an abstract marked with @:callable)?

This was a nice metadata reference for those, btw: https://haxe.io/releases/3.2.0/#Rest-EitherType-selfCall-callable

[clemos]

The problem is not so much with new, construct, @:selfCall.
My point is just with replacing :

    public static inline function enable(name : String) : Void {
        untyped Lib.require("debug").enable(name);
    }
    public static inline function disable() : Void {
        untyped Lib.require("debug").disable();
    }
    public static inline function log(log : Either<DebugInstance, DebugHaxeLogTraceFunction>) : Void {
        untyped Lib.require("debug").log = log;
    }

with

    public static function enable(name : String) : Void;
    public static function disable() : Void:
    public static var log : Either<DebugInstance, DebugHaxeLogTraceFunction>;

when possible.
But once again, maybe I'm missing something ?

[ciscoheat]

Ok, maybe that will work! I'll make an attempt.

[ciscoheat]

I think this is as good as it gets. Xray makes things very complicated, in plain js:

require('x-ray')()('selector...').paginate(3)(function(err, result) { ... })

So I had to make two @:selfCall methods, x and done, resulting in this code:

var xray = new Xray();

xray.x('https://google.com', {
    main: 'title',
    image: xray.x('#gbar a@href', 'title')
})
.done(function(err, result) {
    trace(result);
});

Debug was easier with the static methods, I'm not very happy about the construct method, but I don't see any other way as it is now.

Added a bonus too, a much simpler prettyjson package. :)

[ciscoheat]

If you have suggestions for other names than x and done, let me know.

[clemos]

Ok let's merge it as is :p

[ciscoheat]

Thanks! it's not a total disaster I hope. :)