Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types): Update OrganizationPreview appearance descriptors for OrganizationSwitcher #2158

Conversation

octoper
Copy link
Member

@octoper octoper commented Nov 17, 2023

Description

This PR introduces some breaking changes and some additions to the organzationPreview descriptor

Breaking Changes

  • The organizationSwitcher id has been renamed to organizationSwitcherTrigger and the generated element class will be .cl-organizationPreview__organizationSwitcherTrigger

Additions

  • The organizationSwitcherListedOrganization for styling listed organization in the <OrganizationSwitcher/> and the generated class will be .cl-organizationPreview__organizationSwitcherListedOrganization
  • The organizationSwitcherActiveOrganization for styling the active organization in the <OrganizationSwitcher/> and the generated class will be .cl-organizationPreview__organizationSwitcherActiveOrganizationn

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 17, 2023

🦋 Changeset detected

Latest commit: dfa0e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Major
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper force-pushed the vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances branch from 698b4e1 to 9226af2 Compare November 20, 2023 09:42
@octoper
Copy link
Member Author

octoper commented Nov 20, 2023

!preview

@octoper octoper force-pushed the vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances branch from 9226af2 to 6984731 Compare November 20, 2023 10:36
@octoper octoper marked this pull request as ready for review November 20, 2023 10:37
@octoper octoper self-assigned this Nov 20, 2023
@octoper octoper force-pushed the vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances branch from 6984731 to cfb3015 Compare November 21, 2023 19:19
Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper can you add a changeset outlining the changes and how to migrate? 🙏

@octoper octoper requested a review from BRKalow November 22, 2023 09:10
@octoper
Copy link
Member Author

octoper commented Nov 22, 2023

@BRKalow Added!

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octoper can we double the descriptor i commented about ?

@panteliselef
Copy link
Member

This PR should resolve #1518

@octoper octoper force-pushed the vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances branch from f6081cf to dfa0e52 Compare November 22, 2023 14:02
@octoper octoper added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 429d030 Nov 22, 2023
7 checks passed
@octoper octoper deleted the vaggelis/sdk-861-use-different-css-class-for-organizationpreview-instances branch November 22, 2023 14:21
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
…rs for OrganizationSwitcher (#2158)

* feat(clerk-js,types): Add id's to the organizationPreview descriptor to allow better customization

* feat(clerk-js): Apply changes to ui.retheme

* chore(repo): Added Changeset

* fix(clerk-js): Use the correct element id for the invitation preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants