-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): v5 extra cleanups #2169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f97742f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
sdk-782-extra-cleanup
branch
from
November 20, 2023 11:17
b719e6e
to
40913ce
Compare
nikosdouvlis
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimkl 👏🏻
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 21, 2023
dimkl
force-pushed
the
sdk-782-extra-cleanup
branch
2 times, most recently
from
November 21, 2023 16:33
e988adc
to
83fc9ff
Compare
…BrowserClerkConstructor` typo
dimkl
force-pushed
the
sdk-782-extra-cleanup
branch
from
November 21, 2023 16:34
83fc9ff
to
f97742f
Compare
desiprisg
pushed a commit
that referenced
this pull request
Nov 23, 2023
* chore(clerk-expo): Use isomorphicAtob/isomorhpicBtoa to drop base-64 dep * chore(clerk-sdk-node): Add comment and drop todo in interstitial response errors * fix(clerk-react): Rename `HeadlessBrowserClerkConstrutor` / `HeadlessBrowserClerkConstructor` typo * fix(clerk-react): Drop unused import * chore(backend): Refactor merging of props in request/factory * chore(clerk-react,nextjs): Update JSDoc examples with `withServerSideAuth` * chore(shared): Drop `isLegacyFrontendApiKey` * chore(clerk-js): Drop forgotten default exports * chore(clerk-js): Drop node-fetch dependency * chore(backend): Duplicate test * chore(remix): Rename `noSecretKeyOrApiKeyError` to `noSecretKeyError` * chore(clerk-sdk-node): Re-use `isDevelopmentFromApiKey` from `@clerk/shared` * chore(backend): Drop unused `LoadResourcesOptions` export * chore(*): Rename `isDevelopmentFromApiKey` to `isDevelopmentFromSecretKey` * chore(*): Rename `isProductionFromApiKey` to `isProductionFromSecretKey` * chore(repo): Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes:
isLegacyFrontendApiKey
from@clerk/shared
@clerk/clerk-js
Portal
isProductionFromSecretKey
instead ofisProductionFromApiKey
isDevelopmentFromSecretKey
instead ofisDevelopmentFromApiKey
Changes:
HeadlessBrowserClerkConstrutor
/HeadlessBrowserClerkConstructor
(typo)isomorphicAtob
/isomorhpicBtoa
to replacebase-64
in@clerk/expo
@clerk/backend
clerk clientnode-fetch
dependency from@clerk/backend
@clerk/backend
Review it per commit!
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore