-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): Introduce OrganizationPermissionAPI #2178
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@clerk/clerk-sdk-node': patch | ||
'@clerk/backend': patch | ||
'@clerk/nextjs': patch | ||
--- | ||
|
||
Add OrganizationPermissionAPI for CRUD operations regarding instance level organization permissions. |
69 changes: 69 additions & 0 deletions
69
packages/backend/src/api/endpoints/OrganizationPermissionApi.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import { joinPaths } from '../../util/path'; | ||
import type { DeletedObject, Permission } from '../resources'; | ||
import { AbstractAPI } from './AbstractApi'; | ||
|
||
const basePath = '/organizations_permissions'; | ||
|
||
type GetOrganizationPermissionListParams = { | ||
limit?: number; | ||
offset?: number; | ||
query?: string; | ||
orderBy?: string; | ||
}; | ||
|
||
type CreateParams = { | ||
name: string; | ||
key: string; | ||
description: string; | ||
}; | ||
|
||
type GetOrganizationPermissionParams = { permissionId: string }; | ||
|
||
type UpdateParams = { | ||
name?: string; | ||
key?: string; | ||
description?: string; | ||
}; | ||
|
||
export class OrganizationPermissionAPI extends AbstractAPI { | ||
public async getOrganizationPermissionList(params?: GetOrganizationPermissionListParams) { | ||
return this.request<Permission[]>({ | ||
method: 'GET', | ||
path: basePath, | ||
queryParams: params, | ||
}); | ||
} | ||
|
||
public async createOrganizationPermission(params: CreateParams) { | ||
return this.request<Permission>({ | ||
method: 'POST', | ||
path: basePath, | ||
bodyParams: params, | ||
}); | ||
} | ||
|
||
public async getOrganizationPermission(params: GetOrganizationPermissionParams) { | ||
this.requireId(params.permissionId); | ||
|
||
return this.request<Permission>({ | ||
method: 'GET', | ||
path: joinPaths(basePath, params.permissionId), | ||
}); | ||
} | ||
|
||
public async updateOrganizationPermission(permissionId: string, params: UpdateParams) { | ||
this.requireId(permissionId); | ||
return this.request<Permission>({ | ||
method: 'PATCH', | ||
path: joinPaths(basePath, permissionId), | ||
bodyParams: params, | ||
}); | ||
} | ||
|
||
public async deleteOrganizationPermission(permissionId: string) { | ||
return this.request<DeletedObject>({ | ||
method: 'DELETE', | ||
path: joinPaths(basePath, permissionId), | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import type { PermissionType } from './Enums'; | ||
import type { PermissionJSON } from './JSON'; | ||
|
||
export class Permission { | ||
constructor( | ||
readonly id: string, | ||
readonly name: string, | ||
readonly key: string, | ||
readonly description: string, | ||
readonly type: PermissionType, | ||
readonly createdAt: number, | ||
readonly updatedAt: number, | ||
) {} | ||
|
||
static fromJSON(data: PermissionJSON) { | ||
return new Permission(data.id, data.name, data.key, data.description, data.type, data.created_at, data.updated_at); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 If we have added the
OrganizationMembershipRole
in v4 (release/v4
), we could add the deprecation in the v4 version and replace it with the new API in v5 version (main
branch)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what i was thinking, I merge this and backport it and then create another PR to address this that will not be backported