Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Fallback to custom role name if localization is not provided #2194

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

panteliselef
Copy link
Member

Description

This is valuable for AP where custom localization cannot be applied.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

…ovided

This is valuable for AP where custom localization cannot be applied.
Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 5f9759d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit dd49f93 Nov 23, 2023
7 checks passed
@panteliselef panteliselef deleted the elef/core-931-fallback-role-name branch November 23, 2023 11:53
desiprisg pushed a commit that referenced this pull request Nov 23, 2023
…ovided (#2194)

This is valuable for AP where custom localization cannot be applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants