-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): Improve @clerk/backend DX [Part 6 - token and jwt utils return values] #2377
Merged
SokratisVidros
merged 3 commits into
main
from
sdk-974-improve-dx-backend-p6-verify-token
Dec 15, 2023
Merged
chore(*): Improve @clerk/backend DX [Part 6 - token and jwt utils return values] #2377
SokratisVidros
merged 3 commits into
main
from
sdk-974-improve-dx-backend-p6-verify-token
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 23127d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SokratisVidros
suggested changes
Dec 15, 2023
…Token` return value
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p6-verify-token
branch
2 times, most recently
from
December 15, 2023 19:01
156f4d4
to
9e9e0d1
Compare
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p6-verify-token
branch
from
December 15, 2023 19:18
9e9e0d1
to
88532d1
Compare
… backend `JwtReturnType`
dimkl
force-pushed
the
sdk-974-improve-dx-backend-p6-verify-token
branch
from
December 15, 2023 19:27
88532d1
to
23127d5
Compare
SokratisVidros
approved these changes
Dec 15, 2023
SokratisVidros
deleted the
sdk-974-improve-dx-backend-p6-verify-token
branch
December 15, 2023 21:02
octoper
pushed a commit
that referenced
this pull request
Dec 16, 2023
…urn values] (#2377) * chore(backend,types): Introduce ReturnWithError and use it as `verifyToken` return value * chore(backend,types): Make /jwt subpath utilies to return `ReturnWithError` type * chore(backend,types): Rename and move `ReturnWithError` move types to backend `JwtReturnType`
dimkl
added a commit
to clerk/clerk-docs
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change return values of
signJwt
,hasValidSignature
,decodeJwt
,verifyJwt
,verifyToken
to return
{ data, error }
. Example of keeping the same behaviour using those utilies:Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore