chore(clerk-js,types): Consolidate afterSignOut*Url options and avoid using Dashboard settings
#2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 794b8cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SokratisVidros
approved these changes
Dec 20, 2023
dimkl
force-pushed
the
sdk-720-sign-out
branch
from
f0a480f
to
31ccb27
Compare
dimkl
force-pushed
the
sdk-720-sign-out-consolidate-urls
branch
from
e34700a
to
72129d0
Compare
… using DisplayConfig settings
dimkl
force-pushed
the
sdk-720-sign-out-consolidate-urls
branch
from
72129d0
to
794b8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidate
afterSignOut*Urloptions and avoid using Dashboard settings in ClerkJS.Since this is part of v5 we don't need to have a rollout plan for the AP to release the consolidation. We will pass the afterSignOut*Url values retrieved from the Dashboard Settings to AP ClerkJS initialization to keep the current behaviour.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore