-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No linux-tiles experimental builds since 06-27-2024 #74858
Comments
I assume you mean June, not July, as that date hasn't been reached yet... |
Yeah, of course it's June. Sorry for a typo. |
/confirmed diff --git a/Makefile b/Makefile
index 0dd15eb9fb..fbcaff729b 100644
--- a/Makefile
+++ b/Makefile
@@ -778,7 +778,8 @@ ifeq ($(TILES), 1)
endif
endif
else ifneq ($(NATIVE),emscripten)
- CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2 SDL2_image SDL2_ttf)
+ CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2)
+ CXXFLAGS += $(shell $(PKG_CONFIG) --cflags SDL2_image SDL2_ttf)
ifeq ($(STATIC), 1)
LDFLAGS += $(shell $(PKG_CONFIG) sdl2 --static --libs) EDIT: it needs a bit more (workflow run) |
Same with Android builds, #74841 didn't help. |
Source of solution: CleverRaven#74858 (comment) Co-authored by: andrei <a12l+git@runbox.com>
Source of solution: CleverRaven#74858 (comment) Co-authored by: andrei <a12l+git@runbox.com>
Source of solution: CleverRaven#74858 (comment) Co-authored-by: andrei <a12l+git@runbox.com>
Tested andrei8l's proposed solution, didn't work. I looked into this for a bit but couldn't figure out what has changed to break this. First I thought it was related to ubuntu-latest build image moving to a new release but we specifically use 20.4 for the release build, so not that either. |
It worked for me here; it just needed a bit more work. If that's too invasive, you can try overwriting the system SDL lib with the one we want Untesteddiff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 3d00a0b20c..fe19417959 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -219,17 +219,16 @@ jobs:
if: runner.os == 'Linux' && matrix.mxe == 'none' && matrix.android == 'none' && !matrix.wasm
run: |
sudo apt-get update
- sudo apt-get install libsdl2-dev
+ sudo apt-get install libsdl2-dev libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
+ libsdl2-mixer-dev libpulse-dev ccache gettext parallel
git clone https://github.com/libsdl-org/SDL.git --branch release-2.0.20 --depth 1
cd SDL
mkdir build
cd build
- ../configure
+ ../configure --prefix=/usr
make -j$((`nproc`+0))
sudo make install
cp ../LICENSE.txt ${{ github.workspace }}/LICENSE-SDL.txt
- sudo apt-get install libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
- libsdl2-mixer-dev libpulse-dev ccache gettext parallel
- name: Install Emscripten (WebAssembly)
if: matrix.wasm
uses: mymindstorm/setup-emsdk@v13 |
Does anyone have a fork with working Linux x64 builds? EDIT: I just realized that in-between i was playing CDDA and sleeping this was already fixed and successfully merged. I had this issue open in a tab since yesterday and didn't see it was already closed. |
If builds are broken again, you can always compile it yourself, although it takes quite a long time (which I experienced just yesterday). Even if you are not on Arch, you have working build instructions with this PKGBUILD: https://aur.archlinux.org/packages/cataclysm-dda-git |
Describe the bug
No linux-tiles experimental builds since 06-27-2024
Attach save file
N/A
Steps to reproduce
Expected behavior
Build should be present.
Screenshots
No response
Versions and configuration
N/A
Additional context
No response
The text was updated successfully, but these errors were encountered: