Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No linux-tiles experimental builds since 06-27-2024 #74858

Closed
Void-Seeker opened this issue Jul 1, 2024 · 8 comments · Fixed by #75126
Closed

No linux-tiles experimental builds since 06-27-2024 #74858

Void-Seeker opened this issue Jul 1, 2024 · 8 comments · Fixed by #75126
Labels
Code: Build Issues regarding different builds and build environments (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Void-Seeker
Copy link
Contributor

Void-Seeker commented Jul 1, 2024

Describe the bug

No linux-tiles experimental builds since 06-27-2024

Attach save file

N/A

Steps to reproduce

  1. Try to download recent experimental build for linux with tiles.

Expected behavior

Build should be present.

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@Void-Seeker Void-Seeker added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 1, 2024
@PatrikLundell
Copy link
Contributor

I assume you mean June, not July, as that date hasn't been reached yet...

@Void-Seeker
Copy link
Contributor Author

Yeah, of course it's June. Sorry for a typo.

@Void-Seeker Void-Seeker changed the title No linux-tiles experimental builds since 07-27-2024 No linux-tiles experimental builds since 06-27-2024 Jul 1, 2024
@andrei8l
Copy link
Contributor

andrei8l commented Jul 1, 2024

/confirmed
Include order changed for some reason so the SDL library we need isn't picked up anymore. Maybe this can fix it

diff --git a/Makefile b/Makefile
index 0dd15eb9fb..fbcaff729b 100644
--- a/Makefile
+++ b/Makefile
@@ -778,7 +778,8 @@ ifeq ($(TILES), 1)
       endif
     endif
   else ifneq ($(NATIVE),emscripten)
-    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2 SDL2_image SDL2_ttf)
+    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags sdl2)
+    CXXFLAGS += $(shell $(PKG_CONFIG) --cflags SDL2_image SDL2_ttf)
 
     ifeq ($(STATIC), 1)
       LDFLAGS += $(shell $(PKG_CONFIG) sdl2 --static --libs)

EDIT: it needs a bit more (workflow run)

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 1, 2024
@Cupidatis
Copy link

Same with Android builds, #74841 didn't help.

@Maleclypse Maleclypse added the Code: Build Issues regarding different builds and build environments label Jul 3, 2024
harakka added a commit to harakka/Cataclysm-DDA that referenced this issue Jul 6, 2024
Source of solution: CleverRaven#74858 (comment)

Co-authored by: andrei <a12l+git@runbox.com>
harakka added a commit to harakka/Cataclysm-DDA that referenced this issue Jul 6, 2024
Source of solution: CleverRaven#74858 (comment)

Co-authored by: andrei <a12l+git@runbox.com>
harakka added a commit to harakka/Cataclysm-DDA that referenced this issue Jul 6, 2024
Source of solution: CleverRaven#74858 (comment)

Co-authored-by: andrei <a12l+git@runbox.com>
@harakka
Copy link
Contributor

harakka commented Jul 6, 2024

Tested andrei8l's proposed solution, didn't work. I looked into this for a bit but couldn't figure out what has changed to break this. First I thought it was related to ubuntu-latest build image moving to a new release but we specifically use 20.4 for the release build, so not that either.

@andrei8l
Copy link
Contributor

andrei8l commented Jul 6, 2024

It worked for me here; it just needed a bit more work. If that's too invasive, you can try overwriting the system SDL lib with the one we want

Untested
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 3d00a0b20c..fe19417959 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -219,17 +219,16 @@ jobs:
         if: runner.os == 'Linux' && matrix.mxe == 'none' && matrix.android == 'none' && !matrix.wasm
         run: |
           sudo apt-get update
-          sudo apt-get install libsdl2-dev
+          sudo apt-get install libsdl2-dev libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
+            libsdl2-mixer-dev libpulse-dev ccache gettext parallel
           git clone https://github.com/libsdl-org/SDL.git --branch release-2.0.20 --depth 1
           cd SDL
           mkdir build
           cd build
-          ../configure
+          ../configure --prefix=/usr
           make -j$((`nproc`+0))
           sudo make install
           cp ../LICENSE.txt ${{ github.workspace }}/LICENSE-SDL.txt
-          sudo apt-get install libncursesw5-dev libsdl2-ttf-dev libsdl2-image-dev \
-            libsdl2-mixer-dev libpulse-dev ccache gettext parallel
       - name: Install Emscripten (WebAssembly)
         if: matrix.wasm
         uses: mymindstorm/setup-emsdk@v13

@ingles98
Copy link

ingles98 commented Jul 21, 2024

Does anyone have a fork with working Linux x64 builds?

EDIT: I just realized that in-between i was playing CDDA and sleeping this was already fixed and successfully merged. I had this issue open in a tab since yesterday and didn't see it was already closed.

@NetSysFire
Copy link
Member

If builds are broken again, you can always compile it yourself, although it takes quite a long time (which I experienced just yesterday). Even if you are not on Arch, you have working build instructions with this PKGBUILD: https://aur.archlinux.org/packages/cataclysm-dda-git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants