-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fallback when current version is unavailable #31
Comments
Good catch, @BalusC. I'll address this. Thank you. |
you rock @cleydyr ! |
The proposed implementation to make this plugin more resilient is to iterate through each release and each release artifact and check if an artifact name matches what's expected ( Note: the results returned by the GitHub API seem to be sorted by the date of the tag/commit [1], though it's not documented on the API doc itself. The plugin should not fall back to the locally cached version, as the Dart Sass autodetection is intended to be used in environments with an Internet connection [2], which means it's also able to download at least one version with a matching artifact for all supported os-arch combinations (1.68.0 is one such version). Also, if there was a locally cached release to begin with, it would already be used, and the release download wouldn't be attempted. |
double-check if asset for os-arch is included on release before returning
Issue fixed on version 1.2.0, already deployed and soon to be published on Maven Central. |
Confirmed its in Maven Central. |
Closing this now. |
fab |
It's otherwise blocking builds, see also sass/dart-sass#2110
The plugin should fallback to previous version when current version fails to download. If that also fails then fallback further to last successfully used locally cached version.
The text was updated successfully, but these errors were encountered: