Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CacheDir #126

Merged
merged 2 commits into from
Aug 10, 2023
Merged

add CacheDir #126

merged 2 commits into from
Aug 10, 2023

Conversation

ffalor
Copy link
Contributor

@ffalor ffalor commented Aug 4, 2023

Adds CacheDir to be used in cli/cli#7693

samcoe
samcoe reviewed Aug 6, 2023
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far, would you mind adding a simple test for CacheDir()?

@ffalor ffalor marked this pull request as ready for review August 9, 2023 01:43
@samcoe samcoe merged commit baae867 into cli:trunk Aug 10, 2023
6 checks passed
@ffalor ffalor deleted the clear-cache branch August 10, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffalor @samcoe