Overflow issues

[sir-captainmorgan21]

Thanks for this addon. Its worked great. I've noticed a couple of overflow issues though. For horizontal overflow, I noticed you added negative margins to offset the padding and align the content flush with the edges. This cuts off args tables. I ended up writing css to remove this negative margins, but would love to see that cleaned up so we dont have to maintain that. I actually think it looks ok indented a bit.

The second piece is vertical overflow at the bottom if "showCode" is expanded, and the code snippet is anything more than a few lines. I know its an issue with the tab content being an iframe, so not sure the solution here.

[sir-captainmorgan21]

https://mdxjs.com/docs/using-mdx/#components here it says "Because MDX files are components, they can also import each other:". Can we not render the mdx file like in the example?

[cliedelt]

Hi @sir-captainmorgan21! Thank you for submitting this first issue.

Thanks for this addon. Its worked great. I've noticed a couple of overflow issues though. For horizontal overflow, I noticed you added negative margins to offset the padding and align the content flush with the edges. This cuts off args tables. I ended up writing css to remove this negative margins, but would love to see that cleaned up so we dont have to maintain that. I actually think it looks ok indented a bit.

The second piece is vertical overflow at the bottom if "showCode" is expanded, and the code snippet is anything more than a few lines. I know its an issue with the tab content being an iframe, so not sure the solution here.

I will look into it today. Expect a fix in the next hours/days. If you could provide a sample or screenshot would help much!

https://mdxjs.com/docs/using-mdx/#components here it says "Because MDX files are components, they can also import each other:". Can we not render the mdx file like in the example?

I would love to switch to this approach. I works for mdx. But not with storybook... Storybook requires a context provided to stories inside the mdx file. I tried to dig deep into the storybook code but the storybook api is very very narrow.

[sir-captainmorgan21]

@cliedelt sure thing!

I will look into it today. Expect a fix in the next hours/days. If you could provide a sample or screenshot would help much!

I would love to switch to this approach. I works for mdx. But not with storybook... Storybook requires a context provided to stories inside the mdx file. I tried to dig deep into the storybook code but the storybook api is very very narrow.

Ahh ok. Maybe some help can be provided in the discord? I will try to pull in someone from storybook too

[cliedelt]

Thank you for the screenshot ! Im fixing it right now.

Sure! Im would be very happy to improve the logic of the addon with a deeper storybook integration. My discord is Architect#9240.

[sir-captainmorgan21]

@cliedelt Awesome thanks!