Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Utilities #58

Merged
merged 2 commits into from
Aug 2, 2016
Merged

Feature: Utilities #58

merged 2 commits into from
Aug 2, 2016

Conversation

thomashaw
Copy link
Collaborator

@thomashaw thomashaw commented Aug 1, 2016

Extracted services which do not run on a network socket e.g. package manager update, firewall rules, java etc. into utilities.

Works the same way as . I've converted the existing modules which were suitable into .

Fixed all example scenarios to work with the new tag.

Also renamed the service 'utilities/ntp' directory to 'ntp/ntp' to avoid ambiguous names.

Cheers!

… socket e.g. package manager update, firewall rules, java etc. into utilities
@Jjk422
Copy link
Collaborator

Jjk422 commented Aug 1, 2016

After a quick test of all changed scenarios couldn't find any errors, happy to merge this if everyone else is happy with #58. Gonna look more at the changed code tomorrow, but seems to be working perfectly.

@Jjk422
Copy link
Collaborator

Jjk422 commented Aug 1, 2016

Actually, just remembered something I noticed, the unix_update was moved to the new utility module group, however the windows_update wasn't and is still in services. But other then that its great.

@thomashaw
Copy link
Collaborator Author

Good shout, I've pushed an update.

Cheers.

@Jjk422
Copy link
Collaborator

Jjk422 commented Aug 2, 2016

After looking through all the code changes, I cannot see anything that needs to be changed. I will be happy to merge this if the branch is finished.

@cliffe
Copy link
Owner

cliffe commented Aug 2, 2016

Great. Looks good (though I haven't tested it).

At a later date we could move the shared schema between service and utility to a separate reused schema, to reduce the repetition between the schemas (I had something similar in an earlier version of the overhaul).

@Jjk422, if you have tested the branch, please go ahead and merge. Thanks.

@Jjk422
Copy link
Collaborator

Jjk422 commented Aug 2, 2016

Wanted to make sure everyone was happy with it, due to it being in the core code.
Tested and merged.

@Jjk422 Jjk422 merged commit 96b5248 into cliffe:master Aug 2, 2016
@thomashaw thomashaw deleted the utilities branch December 13, 2016 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants