-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github action matrix to check different version of Java #66
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
Coverage 41.70% 41.70%
Complexity 334 334
=========================================
Files 128 128
Lines 2129 2129
Branches 149 149
=========================================
Hits 888 888
Misses 1151 1151
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I have some request.
The error should be gone after this changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh, there are no required changes, and the strategy
is used in the place where it is not required.
I have made the changes but I still can not get it to build :( |
Well, it is not "still" failing with the same error, this is a new one, and it is related to the jdk16. You can remove also this version, and I will fix this later #67 |
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping me to make the release 0.2.2.
@vincenzopalazzo review this PR.
V1 version for Fixes #23.
Unfortunately I get some Java error (I think it's linked to java / gradlew).
Not being an expert, I am not sure how to fix it.
I think the check file format step is failing for some reason.