Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github action matrix to check different version of Java #66

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

Mrgove10
Copy link

@Mrgove10 Mrgove10 commented Oct 23, 2021

V1 version for Fixes #23.

Unfortunately I get some Java error (I think it's linked to java / gradlew).
Not being an expert, I am not sure how to fix it.
I think the check file format step is failing for some reason.

@Mrgove10 Mrgove10 changed the title GHA V1 Github action matrix usage Oct 23, 2021
@vincenzopalazzo vincenzopalazzo changed the title Github action matrix usage Use Github action matrix to check different version of Java Oct 24, 2021
@vincenzopalazzo vincenzopalazzo added this to the v0.2.3 milestone Oct 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

Merging #66 (62bc381) into master (cb772f8) will not change coverage.
The diff coverage is 60.00%.

❗ Current head 62bc381 differs from pull request most recent head afc13ea. Consider uploading reports for the commit afc13ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage     41.70%   41.70%           
  Complexity      334      334           
=========================================
  Files           128      128           
  Lines          2129     2129           
  Branches        149      149           
=========================================
  Hits            888      888           
  Misses         1151     1151           
  Partials         90       90           
Flag Coverage Δ
unittests 41.70% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/jrpc/service/socket/UnixDomainSocketRpc.java 50.66% <53.84%> (ø)
src/main/java/jrpc/clightning/CLightningRPC.java 61.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb772f8...afc13ea. Read the comment docs.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I have some request.

The error should be gone after this changes

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@Mrgove10
Copy link
Author

I think i have fixed the verrification issue but the build still doesn't pass
image

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, there are no required changes, and the strategy is used in the place where it is not required.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Mrgove10
Copy link
Author

I have made the changes but I still can not get it to build :(

@vincenzopalazzo
Copy link
Member

I have made the changes but I still can not get it to build :(

Well, it is not "still" failing with the same error, this is a new one, and it is related to the jdk16. You can remove also this version, and I will fix this later #67

.github/workflows/build.yml Outdated Show resolved Hide resolved
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

# Title: 

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping me to make the release 0.2.2.

@vincenzopalazzo review this PR.

@vincenzopalazzo vincenzopalazzo merged commit afb037a into clightning4j:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the matrix strategy to improve the Github worflow
3 participants