remove metric button from homepage #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
requested changes
Jun 12, 2022
There was a problem hiding this comment.
As mentioned in some old meetings, we need to track the task that you are working on with an issue.
In this way, we can start to build more content on the developing process, and prove that there is some idea behind this change and it is not a random change.
The question that a PR should answer are:
- Why you are opening the PR and making this change?
- What the fix is for? it is a well-known bug? or just something that you want to add?
- Why I should merge this PR? if none of the questions before contains an answer the no why to merge a PR
|
@vincenzopalazzo Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.
Removing the metric button from the app bar since we are developing the api for metrics and currently the page is breaking.