Add donation component #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
OK, some small comments,
- when you extend an interface you need to implement all the methods and GitHub helps you in the review section in the file
api/LNSocketAPI.tsandapi/JRestAPI.ts - I prefer to use npm and not yarn just because I start with this, maybe we can migrate to yarn? but perhaps this can be another PR. So we can remove the yarn.lock file for now?
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
✅ Deploy Preview for ln-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vincenzopalazzo
force-pushed
the
donation-view
branch
from
b3f858d
to
1a821e4
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
donation-view
branch
from
1a821e4
to
f74cdf3
Compare
vincenzopalazzo
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
I finished this PR with a complete migration of the API and fixed some design mistake in the donation view
Please take a look to this commit and study the APIProvider is you are interested f74cdf3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.