-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Typescript type errors and warnings #3 #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey great work :-D and thanks.
I have only a few change request, but fill free to tell your idea also
I overwrote the types and enabled the props. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks to improving my typescript.
I hope you will continue to contribute.
@vincenzopalazzo review this PR.
Changes
next.config.js
, after that, it serve no purpose. So, I deleted it.as <any>
which should not make any difference in the results.closes #3