Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Typescript type errors and warnings #3 #8

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Fixing Typescript type errors and warnings #3 #8

merged 6 commits into from
Oct 14, 2021

Conversation

mdfahadhossain
Copy link
Contributor

Changes

  1. Type check was disabled on build time and that was the only config in next.config.js, after that, it serve no purpose. So, I deleted it.
  2. I commented out the unexpected & unsupported props.
  3. Sometimes I overwrote the type with as <any> which should not make any difference in the results.
  4. Fixed two warnings that were placed conditionally.
  5. etc...

closes #3

@vincenzopalazzo vincenzopalazzo added the hacktoberfest hacktoberfest label Oct 13, 2021
Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey great work :-D and thanks.

I have only a few change request, but fill free to tell your idea also

components/home/Home.component.tsx Outdated Show resolved Hide resolved
components/home/Home.component.tsx Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
utils/AppUtils.ts Outdated Show resolved Hide resolved
@mdfahadhossain
Copy link
Contributor Author

I overwrote the types and enabled the props.
Pardon me, I forgot to disable prettier this time.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks to improving my typescript.

I hope you will continue to contribute.

@vincenzopalazzo review this PR.

@vincenzopalazzo vincenzopalazzo self-assigned this Oct 14, 2021
@vincenzopalazzo vincenzopalazzo merged commit c1a6980 into clightning4j:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The typescript type checking is off, turn on and make the compiler happy
2 participants