Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure simulation.Δt is the same across MPI ranks #3336

Open
simone-silvestri opened this issue Oct 12, 2023 · 1 comment
Open

Ensure simulation.Δt is the same across MPI ranks #3336

simone-silvestri opened this issue Oct 12, 2023 · 1 comment

Comments

@simone-silvestri
Copy link
Collaborator

we need to add a feature that checks that

sim.Δt

is the same for all ranks upon setting it

@glwagner glwagner changed the title Ensure Δt is the same across MPI ranks Ensure simulation.Δt is the same across MPI ranks Oct 12, 2023
@glwagner
Copy link
Member

Another design is to use something like

set_Δt!(sim, new_Δt)

While overloading setproperty is nicer syntax, it is a little implicit to do an all reduce within setproperty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants