Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README and fix broken links #608

Closed
ali-ramadhan opened this issue Jan 31, 2020 · 2 comments · Fixed by #822
Closed

Update README and fix broken links #608

ali-ramadhan opened this issue Jan 31, 2020 · 2 comments · Fixed by #822
Labels
cleanup 🧹 Paying off technical debt documentation 📜 The sacred scrolls
Milestone
JOSS

Comments

@ali-ramadhan
Copy link
Member

The link to benchmarks.jl in the README.md file is broken.

Originally posted by @funsim in openjournals/joss-reviews#2018 (comment)
@ali-ramadhan ali-ramadhan added cleanup 🧹 Paying off technical debt documentation 📜 The sacred scrolls labels Jan 31, 2020
@ali-ramadhan ali-ramadhan added this to the JOSS milestone Jan 31, 2020
@ali-ramadhan ali-ramadhan mentioned this issue Jan 31, 2020
Closed
38 tasks
@ali-ramadhan ali-ramadhan mentioned this issue Feb 18, 2020
Closed
@glwagner
Copy link
Member

I think this is resolved?

@ali-ramadhan
Copy link
Member Author

Haha so the link is dead again since we don't have a benchmarks.jl file. It should link to the documentation page on performance benchmarks.

I will open a PR.

@ali-ramadhan ali-ramadhan mentioned this issue Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt documentation 📜 The sacred scrolls
Projects
None yet
Milestone
JOSS
Development

Successfully merging a pull request may close this issue.

Fix performance benchmarks dead link in README CliMA/Oceananigans.jl
2 participants
@glwagner @ali-ramadhan