Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify Gatsby cache plugin #194

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Add Netlify Gatsby cache plugin #194

merged 4 commits into from
Jun 9, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 31, 2020

This adds Netlify Gatsby cache plugin.

This plugin was previously added but removed due to a bug reported here.

I could not reproduce the problem, so I think this might have been fixed in the latest Netlify Build since we fixed several caching-related issues.

I am going to try to push to this PR several times in a row to ensure that the problem you encountered is not there anymore. Please keep this PR open until I can confirm everything looks good, thanks!

@RNR1
Copy link
Collaborator

RNR1 commented Mar 31, 2020

i think that's the problem i am experiencing either, thanks!

@ehmicky
Copy link
Contributor Author

ehmicky commented Mar 31, 2020

@RNR1 Could you please describe your problem? I am looking for any additional debugging information.

If possible, please do so by posting a new issue on https://github.com/netlify/build/issues. Thanks!

@RNR1
Copy link
Collaborator

RNR1 commented Mar 31, 2020

well after checking for further info in the issue, i'm not sure that's it, my problem is on getting the images from cache when running npm run develop. then it's not showing the category photos on main page.

@jasonLaster
Copy link
Collaborator

@ehmicky do we want to also restrict the CDN publish to the public directory?

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 1, 2020

It turns out only the public directory is published to the CDN, so all is good there 👍

I have investigated more this issue and summarized my findings in this comment. In a nutshell I would recommend:

@jasonLaster
Copy link
Collaborator

Thanks @ehmicky

@bahmutov
Copy link

bahmutov commented Apr 1, 2020

@ehmicky you are fixing Netlify plugins here and NOT suggesting using Cypress for testing either on Netlify or on GitHub, I am disappointed

@jasonLaster
Copy link
Collaborator

jasonLaster commented Apr 1, 2020

@bahmutov i wouldn't be surprised if every climate site were using cypress in the next couple of months 😉

I'd be happy to pair on our first test anytime you'd like.

@bloudermilk bloudermilk merged commit 6bb1f3e into climatescape:master Jun 9, 2020
@ehmicky ehmicky deleted the feat/gatsby-cache branch June 9, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants