confusion with both senses of primary leagues

[angelsesma]

/ladder subdirectory to be included in the href string

[climu]

Thanks for spotting that. Actually the issue is more of an undocumented and unused feature:

One league is called primary. There is a button in league admin tools to set it:

The url /league/ will always direct to the primary league.

So the issue here is the primary league have not been updated for ages.

Mind that the name is quite confusing since it also refer to primary leagues where player are automatically enrolled.

I think a better fix would be to control the url /league/. I see 2 ways:

1. always redirect it to /ladder/
2. Admins should update the One primary league everymonth.

I guess 1 is better.

Change would happen here:

openstudyroom/league/views.py

Lines 263 to 264 in 0ae71e9

	if event_id is None:
	event = Registry.get_primary_event()

with much inspiration from:

openstudyroom/league/views.py

Lines 307 to 317 in 0ae71e9

	def ladder(request):
	"""A simple view that redirects to the last open ladder league."""
	league = LeagueEvent.objects.filter(
	event_type='ladder',
	is_open=True,
	community__isnull=True
	).order_by('end_time').first()
	return HttpResponseRedirect(reverse(
	'league:results',
	kwargs={'event_id': league.pk})
	)

[angelsesma]

thanks for the heads up! will give it a shot :)