-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same sample ID on multiple lanes causes error #32
Comments
Yes definitely. Thanks for submitting this issue. I will add this in for the next release. |
Thanks! Great work! |
Awesome to hear! It's saved me quite a bit of effort too. Please keep the suggestions coming, I only use sample sheets for a very specific task and will need the community's help in making this useful across applications. |
Sure, I will report if we have any other issues/suggestions. |
@clintval , beware that according to Illumina's reference the
So I assume you should only allow duplicates if the @reisingerf , in your case I am not sure the
Except if you use it to extract data only for specific lanes from a larger flowcell, I guess. |
Thanks @PertuyF. I recognize some Illumina sequencers may allow per lane loading which would support the notion that you could technically have identical I am willing to be permissive on the specification instead of restrictive since sample sheets are used by more platforms than just Illumina (e.g.. 10x). I am open to discussion on how permissive this library should be to restricting the import of sample sheets. Let me dwell on this a bit and I will respond back. @reisingerf, feel free to comment on your specific application and need for this feature. I am interested in the applications you are pursuing. |
We are sequencing cancer samples with using Illumina's NovaSeq. We have a few reasons: |
Hi @reisingerf, I implemented the feature and made a new release as v0.4.0. Let me know how it works for you. I did demo your sample sheet snippet with success. Feel free to update/install from PyPi: $ pip install sample_sheet |
Great thanks! |
Hi, I have a sample sheet that has the same sample ID but on multiple lanes, which in our case can happen quite frequently. This case is currently not supported. Could this be added?
Example [Data] section:
The text was updated successfully, but these errors were encountered: